You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ferruzzi (via GitHub)" <gi...@apache.org> on 2023/08/10 23:31:27 UTC

[GitHub] [airflow] ferruzzi opened a new pull request, #33297: D205 Support - Root files

ferruzzi opened a new pull request, #33297:
URL: https://github.com/apache/airflow/pull/33297

   Part of https://github.com/apache/airflow/issues/10742
   
   D205 asserts that all docstrings must have a one-line summary ending in a period.  If there is more than one sentence then there must be a blank line before the rest of the docstring.  Meeting these requirements could be as simple as adding a newline, or might require some rephrasing.
   
   There are almost a thousand violations in the repo so we're going to have to take this in bites.
   
   ### PLEASE NOTE
   
   There should be zero logic changes in this PR, only changes to docstrings and whitespace.  If you see otherwise, please call it out.
   
   ### Included in this chunk
   
   The last three "root" level files: `setup.py`, `airflow/exceptions.py`, and `airflow/configuration.py` 
   
   ### To test
   
   If you comment out [this line](https://github.com/apache/airflow/blob/main/pyproject.toml#L68) and run pre-commit in main you will get 92 errors.  After these changes, only 73 remain and no files in the list above should be on the list.  After uncommenting that line and rerunning pre-commits, there should be zero regressions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ferruzzi commented on pull request #33297: D205 Support - Root files

Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #33297:
URL: https://github.com/apache/airflow/pull/33297#issuecomment-1675287252

   Mypy was grumpy about some missing type hints.  Not sure what in this PR triggered it, but I've fixed the complaints.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #33297: D205 Support - Root files

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33297:
URL: https://github.com/apache/airflow/pull/33297#issuecomment-1675306964

   > Mypy was grumpy about some missing type hints. Not sure what in this PR triggered it, but I've fixed the complaints.
   
   Mypy is quite often grumpy about unrelated things. The old guy is useful anywwy, so we keep him around anyway


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ferruzzi commented on pull request #33297: D205 Support - Root files

Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #33297:
URL: https://github.com/apache/airflow/pull/33297#issuecomment-1675144606

   huh.  Running `breeze build-docs` locally passes in this branch.
   
   ![image](https://github.com/apache/airflow/assets/1920178/2aeb8a59-7e36-4ff4-9e30-179c2b9aadc1)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ferruzzi commented on pull request #33297: D205 Support - Root files

Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #33297:
URL: https://github.com/apache/airflow/pull/33297#issuecomment-1675069966

   Strange, wonder why the static checks are failing.   It doesn't look related at first glance, but I'll poke at it this afternoon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #33297: D205 Support - Root files

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33297:
URL: https://github.com/apache/airflow/pull/33297


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org