You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2016/06/07 05:52:15 UTC
Review Request 48317: LENS-1164 : Query getting stuck in queue for
inmemory queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48317/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1164
https://issues.apache.org/jira/browse/LENS-1164
Repository: lens
Description
-------
Inmemory queries are not picked from waiting queue even after successful completion of query. With this fix waiting queries will also be processed.
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d85
Diff: https://reviews.apache.org/r/48317/diff/
Testing
-------
Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in local system and it works fine with attached patch.
mvn clean install :
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s]
[INFO] Lens .............................................. SUCCESS [3.360s]
[INFO] Lens API .......................................... SUCCESS [22.328s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.760s]
[INFO] Lens Cube ......................................... SUCCESS [14:41.982s]
[INFO] Lens DB storage ................................... SUCCESS [17.157s]
[INFO] Lens Query Library ................................ SUCCESS [12.136s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s]
[INFO] Lens Server ....................................... SUCCESS [9:12.028s]
[INFO] Lens client ....................................... SUCCESS [1:29.543s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.083s]
[INFO] Lens Examples ..................................... SUCCESS [9.460s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
[INFO] Lens Distribution ................................. SUCCESS [11.536s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s]
[INFO] Lens Regression ................................... SUCCESS [11.726s]
[INFO] Lens UI ........................................... SUCCESS [33.234s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:44.083s
[INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016
[INFO] Final Memory: 190M/2057M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for
inmemory queries
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48317/#review136416
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1089)
<https://reviews.apache.org/r/48317/#comment201457>
Do we need to handle the case where lensServerDao fails to persist the query (Now we are continuing to next query)?
I feel in this case, two things should still be done
1. Calling close on driver
2. Process waiting queries
- Puneet Gupta
On June 7, 2016, 5:52 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48317/
> -----------------------------------------------------------
>
> (Updated June 7, 2016, 5:52 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1164
> https://issues.apache.org/jira/browse/LENS-1164
>
>
> Repository: lens
>
>
> Description
> -------
>
> Inmemory queries are not picked from waiting queue even after successful completion of query. With this fix waiting queries will also be processed.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d85
>
> Diff: https://reviews.apache.org/r/48317/diff/
>
>
> Testing
> -------
>
> Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in local system and it works fine with attached patch.
>
> mvn clean install :
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s]
> [INFO] Lens .............................................. SUCCESS [3.360s]
> [INFO] Lens API .......................................... SUCCESS [22.328s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.760s]
> [INFO] Lens Cube ......................................... SUCCESS [14:41.982s]
> [INFO] Lens DB storage ................................... SUCCESS [17.157s]
> [INFO] Lens Query Library ................................ SUCCESS [12.136s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s]
> [INFO] Lens Server ....................................... SUCCESS [9:12.028s]
> [INFO] Lens client ....................................... SUCCESS [1:29.543s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.083s]
> [INFO] Lens Examples ..................................... SUCCESS [9.460s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
> [INFO] Lens Distribution ................................. SUCCESS [11.536s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s]
> [INFO] Lens Regression ................................... SUCCESS [11.726s]
> [INFO] Lens UI ........................................... SUCCESS [33.234s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:44.083s
> [INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016
> [INFO] Final Memory: 190M/2057M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for
inmemory queries
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48317/#review136773
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1065)
<https://reviews.apache.org/r/48317/#comment202096>
Missed this in previous review, sorry.
We may need to handle the case in getResultSet() where query is closed but could not be added to DB. In this case finished.ctx.setFinishedQueryPersisted(true) will not be set. In this case getResultSet can throw NullPOinterException or create some other issue.
May be we can move FinishedQuery.isCLosed to QueryContext and use it in getResultSet also. If QueryContext.isClosed =true, we can return 404 from getResultSet.
Also incase the server restarts, QueryCOntext.isClosed will be persisted, this will be useful in QueryPurger to make sure we don't try to close this query again.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1104)
<https://reviews.apache.org/r/48317/#comment201861>
Should we change the message to "going ahead with perstsiting the query" ?
- Puneet Gupta
On June 8, 2016, 7:19 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48317/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 7:19 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1164
> https://issues.apache.org/jira/browse/LENS-1164
>
>
> Repository: lens
>
>
> Description
> -------
>
> Inmemory queries are not picked from waiting queue even after successful completion of query. With this fix waiting queries will also be processed.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8fe02aa
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d85
>
> Diff: https://reviews.apache.org/r/48317/diff/
>
>
> Testing
> -------
>
> Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in local system and it works fine with attached patch.
>
> mvn clean install :
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s]
> [INFO] Lens .............................................. SUCCESS [3.360s]
> [INFO] Lens API .......................................... SUCCESS [22.328s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.760s]
> [INFO] Lens Cube ......................................... SUCCESS [14:41.982s]
> [INFO] Lens DB storage ................................... SUCCESS [17.157s]
> [INFO] Lens Query Library ................................ SUCCESS [12.136s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s]
> [INFO] Lens Server ....................................... SUCCESS [9:12.028s]
> [INFO] Lens client ....................................... SUCCESS [1:29.543s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.083s]
> [INFO] Lens Examples ..................................... SUCCESS [9.460s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
> [INFO] Lens Distribution ................................. SUCCESS [11.536s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s]
> [INFO] Lens Regression ................................... SUCCESS [11.726s]
> [INFO] Lens UI ........................................... SUCCESS [33.234s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:44.083s
> [INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016
> [INFO] Final Memory: 190M/2057M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for
inmemory queries
Posted by Sushil Mohanty <su...@gmail.com>.
> On June 8, 2016, 8:50 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 1074
> > <https://reviews.apache.org/r/48317/diff/2/?file=1410943#file1410943line1074>
> >
> > Whats the purpose of this check if we are setting this only in finally clause?
If lensServerDao.insertFinishedQuery fails then finishQuery will not be removed from iterator. Setting this flag to avoid repetition.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48317/#review136611
-----------------------------------------------------------
On June 8, 2016, 7:19 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48317/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 7:19 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1164
> https://issues.apache.org/jira/browse/LENS-1164
>
>
> Repository: lens
>
>
> Description
> -------
>
> Inmemory queries are not picked from waiting queue even after successful completion of query. With this fix waiting queries will also be processed.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8fe02aa
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d85
>
> Diff: https://reviews.apache.org/r/48317/diff/
>
>
> Testing
> -------
>
> Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in local system and it works fine with attached patch.
>
> mvn clean install :
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s]
> [INFO] Lens .............................................. SUCCESS [3.360s]
> [INFO] Lens API .......................................... SUCCESS [22.328s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.760s]
> [INFO] Lens Cube ......................................... SUCCESS [14:41.982s]
> [INFO] Lens DB storage ................................... SUCCESS [17.157s]
> [INFO] Lens Query Library ................................ SUCCESS [12.136s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s]
> [INFO] Lens Server ....................................... SUCCESS [9:12.028s]
> [INFO] Lens client ....................................... SUCCESS [1:29.543s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.083s]
> [INFO] Lens Examples ..................................... SUCCESS [9.460s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
> [INFO] Lens Distribution ................................. SUCCESS [11.536s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s]
> [INFO] Lens Regression ................................... SUCCESS [11.726s]
> [INFO] Lens UI ........................................... SUCCESS [33.234s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:44.083s
> [INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016
> [INFO] Final Memory: 190M/2057M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for
inmemory queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48317/#review136611
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1052)
<https://reviews.apache.org/r/48317/#comment201714>
Whats the purpose of this check if we are setting this only in finally clause?
- Amareshwari Sriramadasu
On June 8, 2016, 7:19 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48317/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 7:19 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1164
> https://issues.apache.org/jira/browse/LENS-1164
>
>
> Repository: lens
>
>
> Description
> -------
>
> Inmemory queries are not picked from waiting queue even after successful completion of query. With this fix waiting queries will also be processed.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8fe02aa
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d85
>
> Diff: https://reviews.apache.org/r/48317/diff/
>
>
> Testing
> -------
>
> Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in local system and it works fine with attached patch.
>
> mvn clean install :
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s]
> [INFO] Lens .............................................. SUCCESS [3.360s]
> [INFO] Lens API .......................................... SUCCESS [22.328s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.760s]
> [INFO] Lens Cube ......................................... SUCCESS [14:41.982s]
> [INFO] Lens DB storage ................................... SUCCESS [17.157s]
> [INFO] Lens Query Library ................................ SUCCESS [12.136s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s]
> [INFO] Lens Server ....................................... SUCCESS [9:12.028s]
> [INFO] Lens client ....................................... SUCCESS [1:29.543s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.083s]
> [INFO] Lens Examples ..................................... SUCCESS [9.460s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
> [INFO] Lens Distribution ................................. SUCCESS [11.536s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s]
> [INFO] Lens Regression ................................... SUCCESS [11.726s]
> [INFO] Lens UI ........................................... SUCCESS [33.234s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:44.083s
> [INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016
> [INFO] Final Memory: 190M/2057M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for
inmemory queries
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48317/#review137484
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On June 13, 2016, 5:04 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48317/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 5:04 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1164
> https://issues.apache.org/jira/browse/LENS-1164
>
>
> Repository: lens
>
>
> Description
> -------
>
> Inmemory queries are not picked from waiting queue even after successful completion of query. With this fix waiting queries will also be processed.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java aebb395
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8fe02aa
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d85
>
> Diff: https://reviews.apache.org/r/48317/diff/
>
>
> Testing
> -------
>
> Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in local system and it works fine with attached patch.
>
> mvn clean install :
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s]
> [INFO] Lens .............................................. SUCCESS [3.360s]
> [INFO] Lens API .......................................... SUCCESS [22.328s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.760s]
> [INFO] Lens Cube ......................................... SUCCESS [14:41.982s]
> [INFO] Lens DB storage ................................... SUCCESS [17.157s]
> [INFO] Lens Query Library ................................ SUCCESS [12.136s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s]
> [INFO] Lens Server ....................................... SUCCESS [9:12.028s]
> [INFO] Lens client ....................................... SUCCESS [1:29.543s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.083s]
> [INFO] Lens Examples ..................................... SUCCESS [9.460s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
> [INFO] Lens Distribution ................................. SUCCESS [11.536s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s]
> [INFO] Lens Regression ................................... SUCCESS [11.726s]
> [INFO] Lens UI ........................................... SUCCESS [33.234s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:44.083s
> [INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016
> [INFO] Final Memory: 190M/2057M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for
inmemory queries
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48317/#review137443
-----------------------------------------------------------
+1
- Puneet Gupta
On June 13, 2016, 5:04 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48317/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 5:04 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1164
> https://issues.apache.org/jira/browse/LENS-1164
>
>
> Repository: lens
>
>
> Description
> -------
>
> Inmemory queries are not picked from waiting queue even after successful completion of query. With this fix waiting queries will also be processed.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java aebb395
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8fe02aa
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d85
>
> Diff: https://reviews.apache.org/r/48317/diff/
>
>
> Testing
> -------
>
> Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in local system and it works fine with attached patch.
>
> mvn clean install :
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s]
> [INFO] Lens .............................................. SUCCESS [3.360s]
> [INFO] Lens API .......................................... SUCCESS [22.328s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.760s]
> [INFO] Lens Cube ......................................... SUCCESS [14:41.982s]
> [INFO] Lens DB storage ................................... SUCCESS [17.157s]
> [INFO] Lens Query Library ................................ SUCCESS [12.136s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s]
> [INFO] Lens Server ....................................... SUCCESS [9:12.028s]
> [INFO] Lens client ....................................... SUCCESS [1:29.543s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.083s]
> [INFO] Lens Examples ..................................... SUCCESS [9.460s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
> [INFO] Lens Distribution ................................. SUCCESS [11.536s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s]
> [INFO] Lens Regression ................................... SUCCESS [11.726s]
> [INFO] Lens UI ........................................... SUCCESS [33.234s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:44.083s
> [INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016
> [INFO] Final Memory: 190M/2057M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for
inmemory queries
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48317/
-----------------------------------------------------------
(Updated June 13, 2016, 5:04 p.m.)
Review request for lens.
Changes
-------
- Addressed review commment.
Bugs: LENS-1164
https://issues.apache.org/jira/browse/LENS-1164
Repository: lens
Description
-------
Inmemory queries are not picked from waiting queue even after successful completion of query. With this fix waiting queries will also be processed.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java aebb395
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8fe02aa
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d85
Diff: https://reviews.apache.org/r/48317/diff/
Testing
-------
Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in local system and it works fine with attached patch.
mvn clean install :
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s]
[INFO] Lens .............................................. SUCCESS [3.360s]
[INFO] Lens API .......................................... SUCCESS [22.328s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.760s]
[INFO] Lens Cube ......................................... SUCCESS [14:41.982s]
[INFO] Lens DB storage ................................... SUCCESS [17.157s]
[INFO] Lens Query Library ................................ SUCCESS [12.136s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s]
[INFO] Lens Server ....................................... SUCCESS [9:12.028s]
[INFO] Lens client ....................................... SUCCESS [1:29.543s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.083s]
[INFO] Lens Examples ..................................... SUCCESS [9.460s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
[INFO] Lens Distribution ................................. SUCCESS [11.536s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s]
[INFO] Lens Regression ................................... SUCCESS [11.726s]
[INFO] Lens UI ........................................... SUCCESS [33.234s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:44.083s
[INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016
[INFO] Final Memory: 190M/2057M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for
inmemory queries
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48317/
-----------------------------------------------------------
(Updated June 8, 2016, 7:19 a.m.)
Review request for lens.
Changes
-------
- Addressed review comment and did some refactoring.
Bugs: LENS-1164
https://issues.apache.org/jira/browse/LENS-1164
Repository: lens
Description
-------
Inmemory queries are not picked from waiting queue even after successful completion of query. With this fix waiting queries will also be processed.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8fe02aa
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d85
Diff: https://reviews.apache.org/r/48317/diff/
Testing
-------
Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in local system and it works fine with attached patch.
mvn clean install :
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s]
[INFO] Lens .............................................. SUCCESS [3.360s]
[INFO] Lens API .......................................... SUCCESS [22.328s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.760s]
[INFO] Lens Cube ......................................... SUCCESS [14:41.982s]
[INFO] Lens DB storage ................................... SUCCESS [17.157s]
[INFO] Lens Query Library ................................ SUCCESS [12.136s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s]
[INFO] Lens Server ....................................... SUCCESS [9:12.028s]
[INFO] Lens client ....................................... SUCCESS [1:29.543s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.083s]
[INFO] Lens Examples ..................................... SUCCESS [9.460s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
[INFO] Lens Distribution ................................. SUCCESS [11.536s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s]
[INFO] Lens Regression ................................... SUCCESS [11.726s]
[INFO] Lens UI ........................................... SUCCESS [33.234s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:44.083s
[INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016
[INFO] Final Memory: 190M/2057M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty