You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/31 10:56:14 UTC

[GitHub] [doris] nextdreamblue commented on a diff in pull request #13830: [meta](recover) change dropInfo and RecoverInfo to GSON

nextdreamblue commented on code in PR #13830:
URL: https://github.com/apache/doris/pull/13830#discussion_r1009282789


##########
fe/fe-core/src/main/java/org/apache/doris/journal/JournalEntity.java:
##########
@@ -196,9 +196,7 @@ public void readFields(DataInput in) throws IOException {
                 break;
             }
             case OperationType.OP_DROP_TABLE: {
-                data = new DropInfo();
-                ((DropInfo) data).readFields(in);
-                isRead = true;
+                data = DropInfo.read(in);

Review Comment:
   ```suggestion
                   data = DropInfo.read(in);
                   isRead = true;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org