You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "argoyal2212 (via GitHub)" <gi...@apache.org> on 2026/08/26 05:52:10 UTC
[PR] [FLINK-XXXXX][runtime-web] Log effective HistoryServer configuration at startup [flink]
argoyal2212 opened a new pull request, #29020:
URL: https://github.com/apache/flink/pull/29020
Logs effective HistoryServer config (storage type, load mode, retention settings) at startup. Follow-up to review feedback on #29008.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40478][runtime-web] Log effective HistoryServer configuration at startup [flink]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #29020:
URL: https://github.com/apache/flink/pull/29020#issuecomment-5464956549
+1, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-XXXXX][runtime-web] Log effective HistoryServer configuration at startup [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29020:
URL: https://github.com/apache/flink/pull/29020#issuecomment-5421254386
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e328bf930d4f7e39a8901c8960275eb28c35ff2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0e328bf930d4f7e39a8901c8960275eb28c35ff2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e328bf930d4f7e39a8901c8960275eb28c35ff2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40478][runtime-web] Log effective HistoryServer configuration at startup [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #29020:
URL: https://github.com/apache/flink/pull/29020#discussion_r3969907294
##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java:
##########
@@ -261,6 +261,19 @@ public HistoryServer(
archiveLoadMode = config.get(HistoryServerOptions.HISTORY_SERVER_ARCHIVE_LOAD_MODE);
HistoryServerOptions.HistoryServerArchiveStorageType archiveStorageType =
config.get(HistoryServerOptions.HISTORY_SERVER_ARCHIVE_STORAGE_TYPE);
+ LOG.info(
+ "HistoryServer effective configuration: storage-type={}, load-mode={}, "
+ + "retained-jobs={}, retained-applications={}, retained-ttl={}, "
+ + "clean-expired-jobs={}, clean-expired-applications={}.",
Review Comment:
**nit:** the `retained-*` and `clean-expired-*` labels match their config keys exactly, but `storage-type` and `load-mode` don't — the real keys use dots (`historyserver.archive.storage.type` and `...load.mode`). Aligning them keeps this line grep-able against the config file. Not a blocker.
```suggestion
"HistoryServer effective configuration: storage.type={}, load.mode={}, "
+ "retained-jobs={}, retained-applications={}, retained-ttl={}, "
+ "clean-expired-jobs={}, clean-expired-applications={}.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40478][runtime-web] Log effective HistoryServer configuration at startup [flink]
Posted by "argoyal2212 (via GitHub)" <gi...@apache.org>.
argoyal2212 commented on PR #29020:
URL: https://github.com/apache/flink/pull/29020#issuecomment-5483692964
@reswqa can you please help with a review ? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40478][runtime-web] Log effective HistoryServer configuration at startup [flink]
Posted by "rmetzger (via GitHub)" <gi...@apache.org>.
rmetzger merged PR #29020:
URL: https://github.com/apache/flink/pull/29020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40478][runtime-web] Log effective HistoryServer configuration at startup [flink]
Posted by "argoyal2212 (via GitHub)" <gi...@apache.org>.
argoyal2212 commented on PR #29020:
URL: https://github.com/apache/flink/pull/29020#issuecomment-5429926960
> Thanks for the patch. I checked this together with #29008 since the PR description says this is a follow-up to feedback there. Would it be better to fold this logging change back into #29008 instead of keeping it as a separate PR?
Thanks for taking a look @Jackeyzhe. I did not mean to have this as a followup rather keep it separate from #29008. Filed a new jira and linked this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-XXXXX][runtime-web] Log effective HistoryServer configuration at startup [flink]
Posted by "Jackeyzhe (via GitHub)" <gi...@apache.org>.
Jackeyzhe commented on PR #29020:
URL: https://github.com/apache/flink/pull/29020#issuecomment-5425624809
Thanks for the patch. I checked this together with #29008 since the PR description says this is a follow-up to feedback there. Would it be better to fold this logging change back into #29008 instead of keeping it as a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org