You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/03 18:42:11 UTC
[GitHub] [geode] dschneider-pivotal opened a new pull request, #7646: GEODE-10206: clean up product references to CMS
dschneider-pivotal opened a new pull request, #7646:
URL: https://github.com/apache/geode/pull/7646
Product comments referring to CMS have been improved.
The ResourceManagerValidator now only does CMS checks if Java version supports CMS.
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal merged pull request #7646: GEODE-10206: clean up product references to CMS
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged PR #7646:
URL: https://github.com/apache/geode/pull/7646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag commented on pull request #7646: GEODE-10206: clean up product references to CMS
Posted by GitBox <gi...@apache.org>.
nabarunnag commented on PR #7646:
URL: https://github.com/apache/geode/pull/7646#issuecomment-1119039599
- Just curious about the last doc change, should there be a line for what to do (or nothing to do) if JVM 14 is used.
- Also, cmsIsAvailable() can be isCMSAvaiable() similar to isJavaVersionAtMost() method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7646: GEODE-10206: clean up product references to CMS
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on PR #7646:
URL: https://github.com/apache/geode/pull/7646#issuecomment-1119155566
LGTM pull request analysis was skipped for 402f9308ea91339cb601b5073bc8512fef4e26b7 by [onichols-pivotal](https://github.com/onichols-pivotal). Analysis of future commits will happen as normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org