You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/04/16 13:10:06 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1571: SOLR-16393: Tweak paths of remaining 'POST /collections' APIs
gerlowskija opened a new pull request, #1571:
URL: https://github.com/apache/solr/pull/1571
https://issues.apache.org/jira/browse/SOLR-16393
# Description
Prior to this commit the v2 APIs for create-collection, create-alias, and restore-collection were all made available as separate "commands" under the "POST /collections" API. This doesn't match the REST-ful design we're hoping to shoot for with v2, and having the APIs all exposed at the same path makes it hard to convert the APIs to JAX-RS or make any further API modifications (see #1453 for more context).
# Solution
This commit fixes this problem by temporarily changing these APIs to use more differentiated paths:
- `POST /api/collections` for create-collection (no change)
- `POST /api/aliases` for create-alias
- `POST /api/backups/backupName/restore` for restore-collection
This brings the APIs closer (but not fully) into line with their more REST-ful v2 forms, and allows us to make further API modifications and convert to JAX-RS individually.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1571: SOLR-16393: Tweak paths of remaining 'POST /collections' APIs
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1571:
URL: https://github.com/apache/solr/pull/1571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org