[GitHub] [arrow] ianmcook commented on a change in pull request #9181: ARROW-11230: [R] Fix build failures on Windows when multiple libarrow binaries found

[GitBox <gi...@apache.org>]

ianmcook commented on a change in pull request #9181:
URL: https://github.com/apache/arrow/pull/9181#discussion_r556157524



##########
File path: r/configure.win
##########
@@ -39,8 +39,9 @@ if [ -d "windows/arrow-$VERSION" ]; then
 else
   # It's possible that the version of the libarrow binary is not identical to the
   # R version, e.g. if the R build is a patch release, so find what the dir is
-  # actually called:
-  RWINLIB="../windows/$(ls windows/ | grep ^arrow-)"
+  # actually called. If there is more than one version present, use the one
+  # with the highest version:
+  RWINLIB="../windows/$(ls windows/ | grep ^arrow- | tail -n 1)"

Review comment:
       `ls` sorts in ascending order by name, so `tail -n 1` gives the highest version string




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org