You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/30 03:23:18 UTC

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3439: Support append_trailing_char_if_absent function

kangkaisen commented on a change in pull request #3439:
URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r417732090



##########
File path: fe/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
##########
@@ -604,6 +604,23 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
             return;
         }
 
+        if (fn.getFunctionName().getFunction().equals("append_trailing_char_if_absent")) {

Review comment:
       ```suggestion
           if (fnName.getFunction().equalsIgnoreCase("append_trailing_char_if_absent")) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org