You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by szvasas <gi...@git.apache.org> on 2018/11/26 10:12:45 UTC

[GitHub] sqoop pull request #51: Sqoop 3411: PostgresMetaConnectIncrementalImportTest...

GitHub user szvasas opened a pull request:

    https://github.com/apache/sqoop/pull/51

    Sqoop 3411: PostgresMetaConnectIncrementalImportTest fails if metastore tables are absent from the database

    It turned out that if the DROP TABLE command in org.apache.sqoop.metastore.MetaConnectIncrementalImportTestBase#resetMetastoreSchema fails the transaction is not rolled back explicitly which leads to an error when the next SQL statement is executed in the same connection.
    
    An extra cleanup logic is added to tearDown method to make sure the tables are deleted.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/szvasas/sqoop SQOOP-3411

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sqoop/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit 15a8e4813db7d126e8bba754ba51abe0c22965fc
Author: Szabolcs Vasas <va...@...>
Date:   2018-11-23T15:36:53Z

    Test fix v2.

commit e06435b2793dadd100d702eb5dc277187f7a3934
Author: Szabolcs Vasas <va...@...>
Date:   2018-11-23T16:00:07Z

    MetaConnectIncrementalImportTestBase now cleanes up tables after the test finishes.

commit 0700f3e2dcfbf3c15bc51c7a1d0297f2950abdc1
Author: Szabolcs Vasas <va...@...>
Date:   2018-11-26T10:08:43Z

    Inner exception variable is renamed.

----


---

[GitHub] sqoop pull request #51: SQOOP-3411: PostgresMetaConnectIncrementalImportTest...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/sqoop/pull/51


---

[GitHub] sqoop issue #51: SQOOP-3411: PostgresMetaConnectIncrementalImportTest fails ...

Posted by ebogi <gi...@git.apache.org>.
Github user ebogi commented on the issue:

    https://github.com/apache/sqoop/pull/51
  
    Hi Szabolcs, your change looks go to me, thank for this fix!


---