You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/31 18:37:51 UTC

[GitHub] [superset] michael-s-molina opened a new pull request #13892: test: Adds tests to the PublishedStatus component

michael-s-molina opened a new pull request #13892:
URL: https://github.com/apache/superset/pull/13892


   ### SUMMARY
   Adds tests to the `PublishedStatus` component.
   
   ### TEST PLAN
   1 - Execute `PublishedStatus` tests
   2 - All tests should pass
   
   @rusackas @junlincc 
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #13892: test: Adds tests to the PublishedStatus component

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13892:
URL: https://github.com/apache/superset/pull/13892#issuecomment-811450564


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=h1) Report
   > Merging [#13892](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=desc) (65a6cae) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.88%`.
   > The diff coverage is `42.85%`.
   
   > :exclamation: Current head 65a6cae differs from pull request most recent head 8fcb7fa. Consider uploading reports for the commit 8fcb7fa to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13892/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13892      +/-   ##
   ==========================================
   - Coverage   77.55%   76.67%   -0.89%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47340      +39     
     Branches     5907     5910       +3     
   ==========================================
   - Hits        36685    36298     -387     
   - Misses      10472    10887     +415     
   - Partials      144      155      +11     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.73% <ø> (-5.30%)` | :arrow_down: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `61.90% <ø> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `55.90% <25.00%> (-0.17%)` | :arrow_down: |
   | [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `35.00% <40.00%> (+1.66%)` | :arrow_up: |
   | [superset/tasks/async\_queries.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYXN5bmNfcXVlcmllcy5weQ==) | `91.07% <62.50%> (-4.93%)` | :arrow_down: |
   | [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
   | [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
   | [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
   | [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `48.43% <0.00%> (-25.00%)` | :arrow_down: |
   | [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `66.66% <0.00%> (-22.81%)` | :arrow_down: |
   | ... and [44 more](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=footer). Last update [d54cc6d...8fcb7fa](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas merged pull request #13892: test: Adds tests to the PublishedStatus component

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13892:
URL: https://github.com/apache/superset/pull/13892


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] yardz commented on a change in pull request #13892: test: Adds tests to the PublishedStatus component

Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13892:
URL: https://github.com/apache/superset/pull/13892#discussion_r605841396



##########
File path: superset-frontend/src/dashboard/components/PublishedStatus/PublishedStatus.test.tsx
##########
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import PublishedStatus from '.';
+
+const defaultProps = {
+  dashboardId: 1,
+  isPublished: false,
+  savePublished: jest.fn(),
+  canEdit: false,
+  canSave: false,
+};
+
+test('renders with unpublished status and readonly permissions', async () => {
+  const tooltip = /This dashboard is not published which means it will not show up in the list of dashboards/;
+  render(<PublishedStatus {...defaultProps} />);
+  expect(screen.getByText('Draft')).toBeInTheDocument();
+  userEvent.hover(screen.getByText('Draft'));
+  expect(await screen.findByText(tooltip)).toBeInTheDocument();
+});
+
+test('renders with unpublished status and write permissions', async () => {
+  const tooltip = /This dashboard is not published, it will not show up in the list of dashboards/;
+  const savePublished = jest.fn();
+  render(
+    <PublishedStatus
+      {...defaultProps}
+      canEdit
+      canSave
+      savePublished={savePublished}
+    />,
+  );
+  expect(screen.getByText('Draft')).toBeInTheDocument();
+  userEvent.hover(screen.getByText('Draft'));
+  expect(await screen.findByText(tooltip)).toBeInTheDocument();
+  expect(savePublished).not.toHaveBeenCalled();
+  userEvent.click(screen.getByText('Draft'));
+  expect(savePublished).toHaveBeenCalledTimes(1);
+});
+
+test('renders with published status and readonly permissions', () => {
+  render(<PublishedStatus {...defaultProps} isPublished />);
+  expect(screen.queryByText('Published')).not.toBeInTheDocument();
+});
+
+test('renders with published status and write permissions', async () => {
+  const tooltip = /This dashboard is published. Click to make it a draft/;
+  const savePublished = jest.fn();
+  render(
+    <PublishedStatus
+      {...defaultProps}
+      isPublished
+      canEdit
+      canSave
+      savePublished={savePublished}
+    />,
+  );
+  expect(screen.getByText('Published')).toBeInTheDocument();
+  userEvent.hover(screen.getByText('Published'));
+  expect(await screen.findByText(tooltip)).toBeInTheDocument();
+  expect(savePublished).not.toHaveBeenCalled();
+  userEvent.click(screen.getByText('Published'));
+  expect(savePublished).toHaveBeenCalledTimes(1);

Review comment:
       Nice! (2)

##########
File path: superset-frontend/src/dashboard/components/PublishedStatus/PublishedStatus.test.tsx
##########
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import PublishedStatus from '.';
+
+const defaultProps = {
+  dashboardId: 1,
+  isPublished: false,
+  savePublished: jest.fn(),
+  canEdit: false,
+  canSave: false,
+};
+
+test('renders with unpublished status and readonly permissions', async () => {
+  const tooltip = /This dashboard is not published which means it will not show up in the list of dashboards/;
+  render(<PublishedStatus {...defaultProps} />);
+  expect(screen.getByText('Draft')).toBeInTheDocument();
+  userEvent.hover(screen.getByText('Draft'));
+  expect(await screen.findByText(tooltip)).toBeInTheDocument();
+});
+
+test('renders with unpublished status and write permissions', async () => {
+  const tooltip = /This dashboard is not published, it will not show up in the list of dashboards/;
+  const savePublished = jest.fn();
+  render(
+    <PublishedStatus
+      {...defaultProps}
+      canEdit
+      canSave
+      savePublished={savePublished}
+    />,
+  );
+  expect(screen.getByText('Draft')).toBeInTheDocument();
+  userEvent.hover(screen.getByText('Draft'));
+  expect(await screen.findByText(tooltip)).toBeInTheDocument();
+  expect(savePublished).not.toHaveBeenCalled();
+  userEvent.click(screen.getByText('Draft'));
+  expect(savePublished).toHaveBeenCalledTimes(1);

Review comment:
       Nice!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13892: test: Adds tests to the PublishedStatus component

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13892:
URL: https://github.com/apache/superset/pull/13892#issuecomment-811450564


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=h1) Report
   > Merging [#13892](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=desc) (65a6cae) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.09%`.
   > The diff coverage is `42.85%`.
   
   > :exclamation: Current head 65a6cae differs from pull request most recent head 8fcb7fa. Consider uploading reports for the commit 8fcb7fa to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13892/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13892      +/-   ##
   ==========================================
   - Coverage   77.55%   77.46%   -0.10%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47340      +39     
     Branches     5907     5910       +3     
   ==========================================
   - Hits        36685    36670      -15     
   - Misses      10472    10526      +54     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.02% <ø> (-0.01%)` | :arrow_down: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `61.90% <ø> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `55.90% <25.00%> (-0.17%)` | :arrow_down: |
   | [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `35.00% <40.00%> (+1.66%)` | :arrow_up: |
   | [superset/tasks/async\_queries.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYXN5bmNfcXVlcmllcy5weQ==) | `91.07% <62.50%> (-4.93%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=footer). Last update [d54cc6d...8fcb7fa](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13892: test: Adds tests to the PublishedStatus component

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13892:
URL: https://github.com/apache/superset/pull/13892#issuecomment-811450564


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=h1) Report
   > Merging [#13892](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=desc) (65a6cae) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.07%`.
   > The diff coverage is `42.85%`.
   
   > :exclamation: Current head 65a6cae differs from pull request most recent head 8fcb7fa. Consider uploading reports for the commit 8fcb7fa to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13892/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13892      +/-   ##
   ==========================================
   - Coverage   77.55%   77.48%   -0.08%     
   ==========================================
     Files         935      935              
     Lines       47301    47319      +18     
     Branches     5907     5907              
   ==========================================
   - Hits        36685    36665      -20     
   - Misses      10472    10510      +38     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.02% <ø> (-0.01%)` | :arrow_down: |
   | javascript | `63.76% <ø> (+0.03%)` | :arrow_up: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `55.90% <25.00%> (-0.17%)` | :arrow_down: |
   | [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `35.00% <40.00%> (+1.66%)` | :arrow_up: |
   | [superset/tasks/async\_queries.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYXN5bmNfcXVlcmllcy5weQ==) | `91.07% <62.50%> (-4.93%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13892/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=footer). Last update [d54cc6d...8fcb7fa](https://codecov.io/gh/apache/superset/pull/13892?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org