You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/04/07 01:37:21 UTC

Review Request 72329: RANGER-2781: updated default policy creation to handle policy-items with no users

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72329/
-----------------------------------------------------------

Review request for ranger, deepak sharma, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Mugdha Varadkar, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2781
    https://issues.apache.org/jira/browse/RANGER-2781


Repository: ranger


Description
-------

- fixed incorrect condition that checked for presence of users, to validate a policy-item. Updated to look for any of these: users/groups/roles
- updated to allow roles and isDelegateAdmin flag to be specified for default policies
- updated to allow creation of multiple policy-items for default policies


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 336911a28 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 47250f3eb 


Diff: https://reviews.apache.org/r/72329/diff/1/


Testing
-------

- verified that default policies are created correctly for policy-items containing only users/groups/roles, and combinations


Thanks,

Madhan Neethiraj


Re: Review Request 72329: RANGER-2781: updated default policy creation to handle policy-items with no users

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72329/#review220235
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On April 7, 2020, 1:37 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72329/
> -----------------------------------------------------------
> 
> (Updated April 7, 2020, 1:37 a.m.)
> 
> 
> Review request for ranger, deepak sharma, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Mugdha Varadkar, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2781
>     https://issues.apache.org/jira/browse/RANGER-2781
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - fixed incorrect condition that checked for presence of users, to validate a policy-item. Updated to look for any of these: users/groups/roles
> - updated to allow roles and isDelegateAdmin flag to be specified for default policies
> - updated to allow creation of multiple policy-items for default policies
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 336911a28 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 47250f3eb 
> 
> 
> Diff: https://reviews.apache.org/r/72329/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that default policies are created correctly for policy-items containing only users/groups/roles, and combinations
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>