You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by db...@apache.org on 2017/04/27 20:26:04 UTC
spark git commit: [SPARK-20483][MINOR] Test for Mesos Coarse mode may
starve other Mesos frameworks
Repository: spark
Updated Branches:
refs/heads/master a4aa4665a -> 039e32ca1
[SPARK-20483][MINOR] Test for Mesos Coarse mode may starve other Mesos frameworks
## What changes were proposed in this pull request?
Add test case for scenarios where executor.cores is set as a
(non)divisor of spark.cores.max
This tests the change in
#17786
## How was this patch tested?
Ran the existing test suite with the new tests
dbtsai
Author: Davis Shepherd <ds...@netflix.com>
Closes #17788 from dgshep/add_mesos_test.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/039e32ca
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/039e32ca
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/039e32ca
Branch: refs/heads/master
Commit: 039e32ca19d113e3be2c09171c7c921698be7ab8
Parents: a4aa466
Author: Davis Shepherd <ds...@netflix.com>
Authored: Thu Apr 27 20:25:52 2017 +0000
Committer: DB Tsai <db...@dbtsai.com>
Committed: Thu Apr 27 20:25:52 2017 +0000
----------------------------------------------------------------------
...esosCoarseGrainedSchedulerBackendSuite.scala | 34 ++++++++++++++++++++
1 file changed, 34 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/039e32ca/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala
----------------------------------------------------------------------
diff --git a/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala b/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala
index c040f05..0418bfb 100644
--- a/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala
+++ b/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala
@@ -199,6 +199,40 @@ class MesosCoarseGrainedSchedulerBackendSuite extends SparkFunSuite
verifyDeclinedOffer(driver, createOfferId("o2"), true)
}
+ test("mesos declines offers with a filter when maxCores not a multiple of executor.cores") {
+ val maxCores = 4
+ val executorCores = 3
+ setBackend(Map(
+ "spark.cores.max" -> maxCores.toString,
+ "spark.executor.cores" -> executorCores.toString
+ ))
+ val executorMemory = backend.executorMemory(sc)
+ offerResources(List(
+ Resources(executorMemory, maxCores + 1),
+ Resources(executorMemory, maxCores + 1)
+ ))
+ verifyTaskLaunched(driver, "o1")
+ verifyDeclinedOffer(driver, createOfferId("o2"), true)
+ }
+
+ test("mesos declines offers with a filter when reached spark.cores.max with executor.cores") {
+ val maxCores = 4
+ val executorCores = 2
+ setBackend(Map(
+ "spark.cores.max" -> maxCores.toString,
+ "spark.executor.cores" -> executorCores.toString
+ ))
+ val executorMemory = backend.executorMemory(sc)
+ offerResources(List(
+ Resources(executorMemory, maxCores + 1),
+ Resources(executorMemory, maxCores + 1),
+ Resources(executorMemory, maxCores + 1)
+ ))
+ verifyTaskLaunched(driver, "o1")
+ verifyTaskLaunched(driver, "o2")
+ verifyDeclinedOffer(driver, createOfferId("o3"), true)
+ }
+
test("mesos assigns tasks round-robin on offers") {
val executorCores = 4
val maxCores = executorCores * 2
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org