You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2016/04/04 09:28:01 UTC

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

GitHub user bhaisaab opened a pull request:

    https://github.com/apache/cloudstack/pull/1462

    ui: fix typo in dashboard's fetchlatest usage

    cc @swill @terbolous @runseb @wido @abhinandanprateek 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack master-fetchlatestuifix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1462
    
----
commit 72b446e091ef49775c79e119b59ed0eb03a42b50
Author: Rohit Yadav <ro...@shapeblue.com>
Date:   2016-04-04T07:23:45Z

    ui: fix typo in dashboard's fetchlatest usage
    
    Signed-off-by: Rohit Yadav <ro...@shapeblue.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-206183076
  
    @swill for the UI fix maybe in future we'll have selenium or jasmine/karma tests but for now we don't have anything other than manual testing for UI changes. Since several people on this PR have confirmed that it works, please merge. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-207058799
  
    @swill all green now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205671313
  
    Thanks @terbolous, fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205178712
  
    Tested this manually by patching dashboard.js and re-gzipping it.
    
    The parameter is now passed as 'fetchLatest' as it should.
    ![Request parameters]
    (https://www.dropbox.com/s/57bfp4jncgv7uge/Screenshot%202016-04-04%2009.48.05.png?dl=1)
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205500155
  
    I believe we have to be reasonable when asking/requiring functional tests.
    After looking at the code, I am ok with the changes and the tests executed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1462


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-206964457
  
    Thanks @swill I totally understand


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205509785
  
    I agree.  @bhaisaab do you mind adding a Jira ticket for this just so we have a record of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205643191
  
    @swill feel free to create a JIRA ticket for this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205488087
  
    I don't think there are any CI tests that will actually test this.  Can we assume the verifications that you guys have done is good enough?  Also, I see that Jenkins has failed, but that seems to be a problems with Jenkins and not necessarily with this PR.  Is this ready to merge???


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-206960333
  
    @swill I guess we have to do push -f; will do just now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-206954412
  
    Is there a way to manually kick off travis on a specific PR, or is the only way to have the author do a `push -f`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205452667
  
    Works as expected, LGTM.
    ![screen shot 2016-04-04 at 21 05 09 pm](https://cloud.githubusercontent.com/assets/1630096/14260084/0fbd98ae-faaa-11e5-8cab-446aaed9b52e.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205654507
  
    @bhaisaab here you go: https://issues.apache.org/jira/browse/CLOUDSTACK-9335
    
    please update the PR and add the issue to the title


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-206961076
  
    @swill done *though for purely JS change we may ignore CI errors if manual testing confirm a fix)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by kiwiflyer <gi...@git.apache.org>.
Github user kiwiflyer commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205512194
  
    Pulled this in manually and tested it.
    
    ![image](https://cloud.githubusercontent.com/assets/17278194/14264343/2654ed6c-fa85-11e5-88ed-6bb7040abbf4.png)
    
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by eriweb <gi...@git.apache.org>.
Github user eriweb commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205507905
  
    Would be great with a jira ticket to track it though :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-205501305
  
    I agree.  I just want to make sure others agree with us...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1462#issuecomment-206963095
  
    Thanks @bhaisaab, sorry to keep having you do that.  I know it is just semantics, but I want to avoid doing `--force` merges.  I got your travis fixes merged in today, so hopefully that will reduce the failures.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---