You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by ji...@apache.org on 2008/09/26 15:36:50 UTC

svn commit: r699316 - in /incubator/log4php/trunk/src/main/php: helpers/LoggerPatternConverter.php spi/LoggerLocationInfo.php

Author: jim
Date: Fri Sep 26 06:36:49 2008
New Revision: 699316

URL: http://svn.apache.org/viewvc?rev=699316&view=rev
Log:
%l Pattern layout raises a protected property access error.
-----------------------------------------------------------

                Key: LOG4PHP-17
                                URL: https://issues.apache.org/jira/browse/LOG4PHP-17
                                            Project: Log4php
                                                     Issue Type: Bug
                                                             Environment: log4php r692607,
                                                             PHP 5.2.4-2ubuntu5.3 with Suhosin-Patch 0.9.6.2,
                                                             Ubuntu 8.04
                                                                        Reporter: Yomei Komiya


Modified:
    incubator/log4php/trunk/src/main/php/helpers/LoggerPatternConverter.php
    incubator/log4php/trunk/src/main/php/spi/LoggerLocationInfo.php

Modified: incubator/log4php/trunk/src/main/php/helpers/LoggerPatternConverter.php
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/helpers/LoggerPatternConverter.php?rev=699316&r1=699315&r2=699316&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/helpers/LoggerPatternConverter.php (original)
+++ incubator/log4php/trunk/src/main/php/helpers/LoggerPatternConverter.php Fri Sep 26 06:36:49 2008
@@ -367,7 +367,7 @@
         $locationInfo = $event->getLocationInformation();
         switch($this->type) {
             case LOG4PHP_LOGGER_PATTERN_PARSER_FULL_LOCATION_CONVERTER:
-                    return $locationInfo->fullInfo;
+                    return $locationInfo->getFullInfo();
             case LOG4PHP_LOGGER_PATTERN_PARSER_METHOD_LOCATION_CONVERTER:
                     return $locationInfo->getMethodName();
             case LOG4PHP_LOGGER_PATTERN_PARSER_LINE_LOCATION_CONVERTER:

Modified: incubator/log4php/trunk/src/main/php/spi/LoggerLocationInfo.php
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/spi/LoggerLocationInfo.php?rev=699316&r1=699315&r2=699316&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/spi/LoggerLocationInfo.php (original)
+++ incubator/log4php/trunk/src/main/php/spi/LoggerLocationInfo.php Fri Sep 26 06:36:49 2008
@@ -115,4 +115,13 @@
     {
         return ($this->methodName === null) ? LOG4PHP_LOGGER_LOCATION_INFO_NA : $this->methodName; 
     }
+
+    /**
+     *  Returns the full information of the caller.
+     */
+    public function getFullInfo()
+    {
+        return ($this->fullInfo === null) ? LOG4PHP_LOGGER_LOCATION_INFO_NA : $this->fullInfo;
+    }
+
 }