You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by sv...@apache.org on 2012/02/24 08:21:05 UTC
svn commit: r1293111 - in /subversion/branches/1.7.x: ./
subversion/include/private/ subversion/libsvn_fs_fs/
subversion/libsvn_subr/ subversion/svn/ subversion/tests/cmdline/
Author: svn-role
Date: Fri Feb 24 07:21:04 2012
New Revision: 1293111
URL: http://svn.apache.org/viewvc?rev=1293111&view=rev
Log:
Reintegrate the 1.7.x-r1210147 branch:
* r1210147, r1202132, r1202333, r1220740, r1220861
Fix the 'svn log --diff' code so that it correctly shows a diff of a
target file (or directory) that was at a different path in the past.
Previously it would error out. A test is included.
Branch:
^/subversion/branches/1.7.x-r1210147
Notes:
I previously said this (r1220740 specifically) depended on r1220783 to
make the test pass on Windows, but it doesn't here; on trunk it does.
r1210147 is the actual fix.
r1202132 and r1202333 were merged for conflict resolution. These revisions
depend on the issue #2873 fix which has been backported in 1.7.2
r1220740 expands the test so that it would fail without r1210147 applied.
r1220861 fixes spurious failure of the new test
Votes:
+1: stsp, julianfoad, cmpilato
Modified:
subversion/branches/1.7.x/ (props changed)
subversion/branches/1.7.x/CHANGES (props changed)
subversion/branches/1.7.x/STATUS
subversion/branches/1.7.x/subversion/include/private/svn_adler32.h (props changed)
subversion/branches/1.7.x/subversion/include/private/svn_string_private.h (props changed)
subversion/branches/1.7.x/subversion/include/private/svn_temp_serializer.h (props changed)
subversion/branches/1.7.x/subversion/libsvn_fs_fs/temp_serializer.c (props changed)
subversion/branches/1.7.x/subversion/libsvn_fs_fs/temp_serializer.h (props changed)
subversion/branches/1.7.x/subversion/libsvn_subr/adler32.c (props changed)
subversion/branches/1.7.x/subversion/libsvn_subr/hash.c (props changed)
subversion/branches/1.7.x/subversion/libsvn_subr/svn_base64.c (props changed)
subversion/branches/1.7.x/subversion/libsvn_subr/svn_temp_serializer.c (props changed)
subversion/branches/1.7.x/subversion/svn/log-cmd.c
subversion/branches/1.7.x/subversion/tests/cmdline/basic_tests.py (props changed)
subversion/branches/1.7.x/subversion/tests/cmdline/diff_tests.py
subversion/branches/1.7.x/subversion/tests/cmdline/log_tests.py
Propchange: subversion/branches/1.7.x/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -18,6 +18,7 @@
/subversion/branches/1.7.x-r1173425:1173429-1176454
/subversion/branches/1.7.x-r1180154:1186224-1186351
/subversion/branches/1.7.x-r1201824:1202121-1207333
+/subversion/branches/1.7.x-r1210147:1213310-1293110
/subversion/branches/1.7.x-r1213331:1213684-1213756
/subversion/branches/1.7.x-r1232221:1232358-1238008
/subversion/branches/1.7.x-r1236343:1236628-1239394
@@ -76,4 +77,4 @@
/subversion/branches/tree-conflicts:868291-873154
/subversion/branches/tree-conflicts-notify:873926-874008
/subversion/branches/uris-as-urls:1060426-1064427
-/subversion/trunk:1146013,1146121,1146219,1146222,1146274,1146492,1146555,1146606,1146620,1146684,1146762,1146781,1146832,1146834,1146870,1146899,1146904,1147293,1147299,1147309,1147882,1148071,1148083,1148094,1148131,1148374,1148424,1148566,1148588,1148652,1148662,1148699,1148853,1148877,1148882,1148936,1149103,1149105,1149135,1149141,1149160,1149228,1149240,1149343,1149371-1149372,1149377,1149398,1149401,1149539,1149572,1149627,1149675,1149701,1149713,1150242,1150254,1150260-1150261,1150266,1150302,1150327,1150344,1150368,1150372,1150441,1150506,1150812,1150853,1151036,1151177,1151610,1151854,1151906,1151911,1152129,1152140,1152189-1152190,1152267,1152282,1152286,1152726,1152809,1153138,1153141,1153416,1153540,1153566,1153799,1153807,1153968,1154009,1154023,1154115,1154119,1154121,1154144,1154155,1154159,1154165,1154215,1154225,1154273,1154278,1154379,1154382,1154461,1154717-1154718,1154733,1154908,1154982,1155015,1155044,1155124,1155131,1155160,1155313,1155334,1155391,115
5404,1156085,1156098,1156216,1156218,1156312,1156527,1156717,1156721,1156750,1156827,1156838,1157416,1158187,1158193-1158194,1158196,1158201,1158207,1158209-1158210,1158217,1158285,1158288,1158303,1158309,1158407,1158419,1158421,1158436,1158455,1158616-1158617,1158634,1158854,1158875,1158886,1158893,1158896,1158919,1158923-1158924,1158929,1158963,1159093,1159098,1159101,1159132,1159136,1159148,1159230,1159275,1159400,1159686,1159760,1159772,1160605,1160671,1160682,1160704-1160705,1160756,1161063,1161080,1161185,1161210,1161683,1161721,1162024,1162033,1162201,1162516,1162880,1162974,1162995,1163243,1163372,1163383,1163557,1163792,1163953,1164027,1164386,1164426,1164517,1164535,1164554,1164580,1164614,1164645,1164760,1164765,1166267,1166500,1166555,1166678,1167062,1167173,1167209,1167269,1167503,1167659,1167681,1169524,1169531,1169650,1171708,1173111,1173425,1173639,1174051,1174060,1174652,1174761,1174797-1174798,1174806,1175888,1176915,1176949,1177001,1177492,1177732,1178280,
1178282,1178942,1179680,1179767,1179776,1180154,1181090,1181110,1181155,1181215,1181609,1181666,1182115,1182527,1182771,1182904,1182909,1183054,1183263,1183347,1185222,1185242,1185280,1185282,1185730,1185738,1185746,1185763,1185768,1185886,1185911,1185918,1186059,1186092,1186101,1186107,1186109,1186121,1186231,1186240,1186422,1186434,1186732,1186755,1186784,1186815,1186928,1186944,1186981,1186983,1187311,1187676,1187695,1188609,1188652,1188677,1188762,1188774,1189190,1189261,1189395,1189580,1189665,1195480,1197135,1197998,1199876,1199950,1200837,1201002,1201072,1201419,1201824,1202135,1202187,1202630,1202807,1203546,1203651,1203653,1204167,1204478,1204610,1204673,1205188,1205193,1205209,1205726,1205839,1205848,1206523,1206533,1206576,1206718-1206719,1206724,1206741,1206748,1207555,1207656,1207663,1207808,1207823,1207858,1207949,1208840,1209631,1209654,1210195,1211483,1211859,1211885,1212476,1212482,1212484,1213331,1213673,1213681,1213690,1213711,1213716,1214139,1215260,12152
88,1215374-1215375,1215379,1220742,1220750,1221178,1221303,1221767,1221780,1221793,1222521,1222628,1222644,1222693,1222699,1225491,1226597,1227146,1227237,1227250,1227352,1227372,1227384-1227385,1227900,1228340,1229252,1229303,1229677,1229833,1229980,1230212,1231029,1231944-1231945,1232202,1232207,1232221-1232222,1232413,1235264,1235296,1235302,1235736,1236163,1236173,1236283,1236343,1237720,1239382,1239596,1239631,1239655,1239747,1240314,1240485,1240752,1241530,1241553,1241713,1241726,1242116,1242537,1242607
+/subversion/trunk:1146013,1146121,1146219,1146222,1146274,1146492,1146555,1146606,1146620,1146684,1146762,1146781,1146832,1146834,1146870,1146899,1146904,1147293,1147299,1147309,1147882,1148071,1148083,1148094,1148131,1148374,1148424,1148566,1148588,1148652,1148662,1148699,1148853,1148877,1148882,1148936,1149103,1149105,1149135,1149141,1149160,1149228,1149240,1149343,1149371-1149372,1149377,1149398,1149401,1149539,1149572,1149627,1149675,1149701,1149713,1150242,1150254,1150260-1150261,1150266,1150302,1150327,1150344,1150368,1150372,1150441,1150506,1150812,1150853,1151036,1151177,1151610,1151854,1151906,1151911,1152129,1152140,1152189-1152190,1152267,1152282,1152286,1152726,1152809,1153138,1153141,1153416,1153540,1153566,1153799,1153807,1153968,1154009,1154023,1154115,1154119,1154121,1154144,1154155,1154159,1154165,1154215,1154225,1154273,1154278,1154379,1154382,1154461,1154717-1154718,1154733,1154908,1154982,1155015,1155044,1155124,1155131,1155160,1155313,1155334,1155391,115
5404,1156085,1156098,1156216,1156218,1156312,1156527,1156717,1156721,1156750,1156827,1156838,1157416,1158187,1158193-1158194,1158196,1158201,1158207,1158209-1158210,1158217,1158285,1158288,1158303,1158309,1158407,1158419,1158421,1158436,1158455,1158616-1158617,1158634,1158854,1158875,1158886,1158893,1158896,1158919,1158923-1158924,1158929,1158963,1159093,1159098,1159101,1159132,1159136,1159148,1159230,1159275,1159400,1159686,1159760,1159772,1160605,1160671,1160682,1160704-1160705,1160756,1161063,1161080,1161185,1161210,1161683,1161721,1162024,1162033,1162201,1162516,1162880,1162974,1162995,1163243,1163372,1163383,1163557,1163792,1163953,1164027,1164386,1164426,1164517,1164535,1164554,1164580,1164614,1164645,1164760,1164765,1166267,1166500,1166555,1166678,1167062,1167173,1167209,1167269,1167503,1167659,1167681,1169524,1169531,1169650,1171708,1173111,1173425,1173639,1174051,1174060,1174652,1174761,1174797-1174798,1174806,1175888,1176915,1176949,1177001,1177492,1177732,1178280,
1178282,1178942,1179680,1179767,1179776,1180154,1181090,1181110,1181155,1181215,1181609,1181666,1182115,1182527,1182771,1182904,1182909,1183054,1183263,1183347,1185222,1185242,1185280,1185282,1185730,1185738,1185746,1185763,1185768,1185886,1185911,1185918,1186059,1186092,1186101,1186107,1186109,1186121,1186231,1186240,1186422,1186434,1186732,1186755,1186784,1186815,1186928,1186944,1186981,1186983,1187311,1187676,1187695,1188609,1188652,1188677,1188762,1188774,1189190,1189261,1189395,1189580,1189665,1195480,1197135,1197998,1199876,1199950,1200837,1201002,1201072,1201419,1201824,1202132,1202135,1202187,1202333,1202630,1202807,1203546,1203651,1203653,1204167,1204478,1204610,1204673,1205188,1205193,1205209,1205726,1205839,1205848,1206523,1206533,1206576,1206718-1206719,1206724,1206741,1206748,1207555,1207656,1207663,1207808,1207823,1207858,1207949,1208840,1209631,1209654,1210147,1210195,1211483,1211859,1211885,1212476,1212482,1212484,1213331,1213673,1213681,1213690,1213711,12137
16,1214139,1215260,1215288,1215374-1215375,1215379,1220740,1220742,1220750,1220861,1221178,1221303,1221767,1221780,1221793,1222521,1222628,1222644,1222693,1222699,1225491,1226597,1227146,1227237,1227250,1227352,1227372,1227384-1227385,1227900,1228340,1229252,1229303,1229677,1229833,1229980,1230212,1231029,1231944-1231945,1232202,1232207,1232221-1232222,1232413,1235264,1235296,1235302,1235736,1236163,1236173,1236283,1236343,1237720,1239382,1239596,1239631,1239655,1239747,1240314,1240485,1240752,1241530,1241553,1241713,1241726,1242116,1242537,1242607
Propchange: subversion/branches/1.7.x/CHANGES
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -5,6 +5,7 @@
/subversion/branches/1.7.x-r1152189/CHANGES:1152759-1154249
/subversion/branches/1.7.x-r1155160/CHANGES:1158704-1159223
/subversion/branches/1.7.x-r1159093/CHANGES:1159097-1159230
+/subversion/branches/1.7.x-r1210147/CHANGES:1213310-1293110
/subversion/branches/atomic-revprop/CHANGES:965046-1000689
/subversion/branches/bdb-reverse-deltas/CHANGES:872050-872529
/subversion/branches/diff-callbacks3/CHANGES:870059-870761
Modified: subversion/branches/1.7.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/STATUS?rev=1293111&r1=1293110&r2=1293111&view=diff
==============================================================================
--- subversion/branches/1.7.x/STATUS (original)
+++ subversion/branches/1.7.x/STATUS Fri Feb 24 07:21:04 2012
@@ -145,23 +145,6 @@ Veto-blocked changes:
Approved changes:
=================
- * r1210147, r1202132, r1202333, r1220740, r1220861
- Fix the 'svn log --diff' code so that it correctly shows a diff of a
- target file (or directory) that was at a different path in the past.
- Previously it would error out. A test is included.
- Branch:
- ^/subversion/branches/1.7.x-r1210147
- Notes:
- I previously said this (r1220740 specifically) depended on r1220783 to
- make the test pass on Windows, but it doesn't here; on trunk it does.
- r1210147 is the actual fix.
- r1202132 and r1202333 were merged for conflict resolution. These revisions
- depend on the issue #2873 fix which has been backported in 1.7.2
- r1220740 expands the test so that it would fail without r1210147 applied.
- r1220861 fixes spurious failure of the new test
- Votes:
- +1: stsp, julianfoad, cmpilato
-
* r1238121
Fix incorrect url construction in libsvn_ra_serf when svn_ra_get_dir2() is
called against a HTTPv2 server with a SVN_INVALID_REVNUM revision.
Propchange: subversion/branches/1.7.x/subversion/include/private/svn_adler32.h
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -1,4 +1,5 @@
/subversion/branches/1.5.x-r30215/subversion/libsvn_diff/diff.h:870312
+/subversion/branches/1.7.x-r1210147/subversion/include/private/svn_adler32.h:1213310-1293110
/subversion/branches/atomic-revprop/subversion/libsvn_diff/diff.h:965046-1000689
/subversion/branches/bdb-reverse-deltas/subversion/libsvn_diff/diff.h:872050-872529
/subversion/branches/diff-callbacks3/subversion/libsvn_diff/diff.h:870059-870761
Propchange: subversion/branches/1.7.x/subversion/include/private/svn_string_private.h
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -1,4 +1,5 @@
/subversion/branches/1.5.x-r30215/subversion/include/svn_string.h:870312
+/subversion/branches/1.7.x-r1210147/subversion/include/private/svn_string_private.h:1213310-1293110
/subversion/branches/atomic-revprop/subversion/include/svn_string.h:965046-1000689
/subversion/branches/bdb-reverse-deltas/subversion/include/svn_string.h:872050-872529
/subversion/branches/diff-callbacks3/subversion/include/svn_string.h:870059-870761
Propchange: subversion/branches/1.7.x/subversion/include/private/svn_temp_serializer.h
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -1,2 +1,3 @@
+/subversion/branches/1.7.x-r1210147/subversion/include/private/svn_temp_serializer.h:1213310-1293110
/subversion/branches/revprop-packing/subversion/include/private/svn_temp_serializer.h:1143907,1143971,1144017,1144568
/subversion/trunk/subversion/include/private/svn_temp_serializer.h:1067687-1072301,1189190,1189395,1207858,1207949,1210195,1211483,1211859,1211885
Propchange: subversion/branches/1.7.x/subversion/libsvn_fs_fs/temp_serializer.c
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -1,2 +1,3 @@
+/subversion/branches/1.7.x-r1210147/subversion/libsvn_fs_fs/temp_serializer.c:1213310-1293110
/subversion/branches/revprop-packing/subversion/libsvn_fs_fs/temp_serializer.c:1143907,1143971,1144017,1144568
/subversion/trunk/subversion/libsvn_fs_fs/temp_serializer.c:1067687-1072301,1189190,1189395,1207858,1207949,1210195,1211483,1211859,1211885
Propchange: subversion/branches/1.7.x/subversion/libsvn_fs_fs/temp_serializer.h
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -1,2 +1,3 @@
+/subversion/branches/1.7.x-r1210147/subversion/libsvn_fs_fs/temp_serializer.h:1213310-1293110
/subversion/branches/revprop-packing/subversion/libsvn_fs_fs/temp_serializer.h:1143907,1143971,1144017,1144568
/subversion/trunk/subversion/libsvn_fs_fs/temp_serializer.h:1067687-1072301,1189190,1189395,1207858,1207949,1210195,1211483,1211859,1211885
Propchange: subversion/branches/1.7.x/subversion/libsvn_subr/adler32.c
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -1,3 +1,4 @@
+/subversion/branches/1.7.x-r1210147/subversion/libsvn_subr/adler32.c:1213310-1293110
/subversion/branches/diff-optimizations/subversion/libsvn_subr/adler32.c:1031270-1037352
/subversion/branches/diff-optimizations-bytes/subversion/libsvn_subr/adler32.c:1037353-1067789
/subversion/branches/performance/subversion/libsvn_subr/adler32.c:1067697-1078365
Propchange: subversion/branches/1.7.x/subversion/libsvn_subr/hash.c
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -1,4 +1,5 @@
/subversion/branches/1.5.x-r30215/subversion/libsvn_subr/hash.c:870312
+/subversion/branches/1.7.x-r1210147/subversion/libsvn_subr/hash.c:1213310-1293110
/subversion/branches/atomic-revprop/subversion/libsvn_subr/hash.c:965046-1000689
/subversion/branches/bdb-reverse-deltas/subversion/libsvn_subr/hash.c:872050-872529
/subversion/branches/diff-callbacks3/subversion/libsvn_subr/hash.c:870059-870761
Propchange: subversion/branches/1.7.x/subversion/libsvn_subr/svn_base64.c
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -18,6 +18,7 @@
/subversion/branches/1.7.x-r1173425/subversion/libsvn_subr/svn_base64.c:1173429-1176454
/subversion/branches/1.7.x-r1180154/subversion/libsvn_subr/svn_base64.c:1186224-1186351
/subversion/branches/1.7.x-r1201824/subversion/libsvn_subr/svn_base64.c:1202121-1207333
+/subversion/branches/1.7.x-r1210147/subversion/libsvn_subr/svn_base64.c:1213310-1293110
/subversion/branches/1.7.x-r1213331/subversion/libsvn_subr/svn_base64.c:1213684-1213756
/subversion/branches/1.7.x-r1232221/subversion/libsvn_subr/svn_base64.c:1232358-1238008
/subversion/branches/1.7.x-r1236343/subversion/libsvn_subr/svn_base64.c:1236628-1239394
@@ -76,4 +77,4 @@
/subversion/branches/tree-conflicts/subversion/libsvn_subr/svn_base64.c:868291-873154
/subversion/branches/tree-conflicts-notify/subversion/libsvn_subr/svn_base64.c:873926-874008
/subversion/branches/uris-as-urls/subversion/libsvn_subr/svn_base64.c:1060426-1064427
-/subversion/trunk/subversion/libsvn_subr/svn_base64.c:1146013,1146121,1146219,1146222,1146274,1146492,1146555,1146606,1146620,1146684,1146762,1146781,1146832,1146834,1146870,1146899,1146904,1147293,1147299,1147309,1147882,1148071,1148083,1148094,1148131,1148374,1148424,1148566,1148588,1148652,1148662,1148699,1148853,1148877,1148882,1148936,1149103,1149105,1149135,1149141,1149160,1149228,1149240,1149343,1149371-1149372,1149377,1149398,1149401,1149539,1149572,1149627,1149675,1149701,1149713,1150242,1150254,1150260-1150261,1150266,1150302,1150327,1150344,1150368,1150372,1150441,1150506,1150812,1150853,1151036,1151177,1151610,1151854,1151906,1151911,1152129,1152140,1152189-1152190,1152267,1152282,1152286,1152726,1152809,1153138,1153141,1153416,1153540,1153566,1153799,1153807,1153968,1154009,1154023,1154115,1154119,1154121,1154144,1154155,1154159,1154165,1154215,1154225,1154273,1154278,1154379,1154382,1154461,1154717-1154718,1154733,1154908,1154982,1155015,1155044,1155124,1155131
,1155160,1155313,1155334,1155391,1155404,1156085,1156098,1156216,1156218,1156312,1156527,1156717,1156721,1156750,1156827,1156838,1157416,1158187,1158193-1158194,1158196,1158201,1158207,1158209-1158210,1158217,1158285,1158288,1158303,1158309,1158407,1158419,1158421,1158436,1158455,1158616-1158617,1158634,1158854,1158875,1158886,1158893,1158896,1158919,1158923-1158924,1158929,1158963,1159093,1159098,1159101,1159132,1159136,1159148,1159230,1159275,1159400,1159686,1159760,1159772,1160605,1160671,1160682,1160704-1160705,1160756,1161063,1161080,1161185,1161210,1161683,1161721,1162024,1162033,1162201,1162516,1162880,1162974,1162995,1163243,1163372,1163383,1163557,1163792,1163953,1164027,1164386,1164426,1164517,1164535,1164554,1164580,1164614,1164645,1164760,1164765,1166267,1166500,1166555,1166678,1167062,1167173,1167209,1167269,1167503,1167659,1167681,1169524,1169531,1169650,1171708,1173111,1173425,1173639,1174051,1174060,1174652,1174761,1174797-1174798,1174806,1175888,1176915,1176
949,1177001,1177492,1177732,1178280,1178282,1178942,1179680,1179767,1179776,1180154,1181090,1181110,1181155,1181215,1181609,1181666,1182115,1182527,1182771,1182904,1182909,1183054,1183263,1183347,1185222,1185242,1185280,1185282,1185730,1185738,1185746,1185763,1185768,1185886,1185911,1185918,1186059,1186092,1186101,1186107,1186109,1186121,1186231,1186240,1186422,1186434,1186732,1186755,1186784,1186815,1186928,1186944,1186981,1186983,1187311,1187676,1187695,1188609,1188652,1188677,1188762,1188774,1189190,1189261,1189395,1189580,1189665,1195480,1197135,1197998,1199876,1199950,1200837,1201002,1201072,1201419,1201824,1202135,1202187,1202630,1202807,1203546,1203651,1203653,1204167,1204478,1204610,1204673,1205188,1205193,1205209,1205726,1205839,1205848,1206523,1206533,1206576,1206718-1206719,1206724,1206741,1206748,1207555,1207656,1207663,1207808,1207823,1207858,1207949,1208840,1209631,1209654,1210195,1211483,1211859,1211885,1212476,1212482,1212484,1213331,1213673,1213681,1213690,1
213711,1213716,1214139,1215260,1215288,1215374-1215375,1215379,1220742,1220750,1221178,1221303,1221767,1221780,1221793,1222521,1222628,1222644,1222693,1222699,1225491,1226597,1227146,1227237,1227250,1227352,1227372,1227384-1227385,1227900,1228340,1229252,1229303,1229677,1229833,1229980,1230212,1231029,1231944-1231945,1232202,1232207,1232221-1232222,1232413,1235264,1235296,1235302,1235736,1236163,1236173,1236283,1236343,1237720,1239382,1239596,1239631,1239655,1239747,1240314,1240485,1240752,1241530,1241553,1241713,1241726,1242116,1242337
+/subversion/trunk/subversion/libsvn_subr/svn_base64.c:1146013,1146121,1146219,1146222,1146274,1146492,1146555,1146606,1146620,1146684,1146762,1146781,1146832,1146834,1146870,1146899,1146904,1147293,1147299,1147309,1147882,1148071,1148083,1148094,1148131,1148374,1148424,1148566,1148588,1148652,1148662,1148699,1148853,1148877,1148882,1148936,1149103,1149105,1149135,1149141,1149160,1149228,1149240,1149343,1149371-1149372,1149377,1149398,1149401,1149539,1149572,1149627,1149675,1149701,1149713,1150242,1150254,1150260-1150261,1150266,1150302,1150327,1150344,1150368,1150372,1150441,1150506,1150812,1150853,1151036,1151177,1151610,1151854,1151906,1151911,1152129,1152140,1152189-1152190,1152267,1152282,1152286,1152726,1152809,1153138,1153141,1153416,1153540,1153566,1153799,1153807,1153968,1154009,1154023,1154115,1154119,1154121,1154144,1154155,1154159,1154165,1154215,1154225,1154273,1154278,1154379,1154382,1154461,1154717-1154718,1154733,1154908,1154982,1155015,1155044,1155124,1155131
,1155160,1155313,1155334,1155391,1155404,1156085,1156098,1156216,1156218,1156312,1156527,1156717,1156721,1156750,1156827,1156838,1157416,1158187,1158193-1158194,1158196,1158201,1158207,1158209-1158210,1158217,1158285,1158288,1158303,1158309,1158407,1158419,1158421,1158436,1158455,1158616-1158617,1158634,1158854,1158875,1158886,1158893,1158896,1158919,1158923-1158924,1158929,1158963,1159093,1159098,1159101,1159132,1159136,1159148,1159230,1159275,1159400,1159686,1159760,1159772,1160605,1160671,1160682,1160704-1160705,1160756,1161063,1161080,1161185,1161210,1161683,1161721,1162024,1162033,1162201,1162516,1162880,1162974,1162995,1163243,1163372,1163383,1163557,1163792,1163953,1164027,1164386,1164426,1164517,1164535,1164554,1164580,1164614,1164645,1164760,1164765,1166267,1166500,1166555,1166678,1167062,1167173,1167209,1167269,1167503,1167659,1167681,1169524,1169531,1169650,1171708,1173111,1173425,1173639,1174051,1174060,1174652,1174761,1174797-1174798,1174806,1175888,1176915,1176
949,1177001,1177492,1177732,1178280,1178282,1178942,1179680,1179767,1179776,1180154,1181090,1181110,1181155,1181215,1181609,1181666,1182115,1182527,1182771,1182904,1182909,1183054,1183263,1183347,1185222,1185242,1185280,1185282,1185730,1185738,1185746,1185763,1185768,1185886,1185911,1185918,1186059,1186092,1186101,1186107,1186109,1186121,1186231,1186240,1186422,1186434,1186732,1186755,1186784,1186815,1186928,1186944,1186981,1186983,1187311,1187676,1187695,1188609,1188652,1188677,1188762,1188774,1189190,1189261,1189395,1189580,1189665,1195480,1197135,1197998,1199876,1199950,1200837,1201002,1201072,1201419,1201824,1202132,1202135,1202187,1202333,1202630,1202807,1203546,1203651,1203653,1204167,1204478,1204610,1204673,1205188,1205193,1205209,1205726,1205839,1205848,1206523,1206533,1206576,1206718-1206719,1206724,1206741,1206748,1207555,1207656,1207663,1207808,1207823,1207858,1207949,1208840,1209631,1209654,1210147,1210195,1211483,1211859,1211885,1212476,1212482,1212484,1213331,1
213673,1213681,1213690,1213711,1213716,1214139,1215260,1215288,1215374-1215375,1215379,1220740,1220742,1220750,1221178,1221303,1221767,1221780,1221793,1222521,1222628,1222644,1222693,1222699,1225491,1226597,1227146,1227237,1227250,1227352,1227372,1227384-1227385,1227900,1228340,1229252,1229303,1229677,1229833,1229980,1230212,1231029,1231944-1231945,1232202,1232207,1232221-1232222,1232413,1235264,1235296,1235302,1235736,1236163,1236173,1236283,1236343,1237720,1239382,1239596,1239631,1239655,1239747,1240314,1240485,1240752,1241530,1241553,1241713,1241726,1242116,1242337,1242537,1242607
Propchange: subversion/branches/1.7.x/subversion/libsvn_subr/svn_temp_serializer.c
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -1,2 +1,3 @@
+/subversion/branches/1.7.x-r1210147/subversion/libsvn_subr/svn_temp_serializer.c:1213310-1293110
/subversion/branches/revprop-packing/subversion/libsvn_subr/svn_temp_serializer.c:1143907,1143971,1144017,1144568
/subversion/trunk/subversion/libsvn_subr/svn_temp_serializer.c:1067687-1072301,1189190,1189395,1207858,1207949,1210195,1211483,1211859,1211885
Modified: subversion/branches/1.7.x/subversion/svn/log-cmd.c
URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/subversion/svn/log-cmd.c?rev=1293111&r1=1293110&r2=1293111&view=diff
==============================================================================
--- subversion/branches/1.7.x/subversion/svn/log-cmd.c (original)
+++ subversion/branches/1.7.x/subversion/svn/log-cmd.c Fri Feb 24 07:21:04 2012
@@ -51,8 +51,9 @@ struct log_receiver_baton
/* Client context. */
svn_client_ctx_t *ctx;
- /* The URL target of the log operation. */
- const char *target_url;
+ /* The target of the log operation. */
+ const char *target_path_or_url;
+ svn_opt_revision_t target_peg_revision;
/* Don't print log message body nor its line count. */
svn_boolean_t omit_log_message;
@@ -283,7 +284,6 @@ log_entry_receiver(void *baton,
apr_status_t status;
svn_opt_revision_t start_revision;
svn_opt_revision_t end_revision;
- svn_error_t *err;
if ((status = apr_file_open_stdout(&outfile, pool)))
return svn_error_wrap_apr(status, _("Can't open stdout"));
@@ -303,82 +303,22 @@ log_entry_receiver(void *baton,
end_revision.value.number = log_entry->revision;
SVN_ERR(svn_cmdline_printf(pool, _("\n")));
- err = svn_client_diff5(diff_options,
- lb->target_url,
- &start_revision,
- lb->target_url,
- &end_revision,
- NULL,
- lb->depth,
- FALSE, /* ignore ancestry */
- TRUE, /* no diff deleted */
- FALSE, /* show copies as adds */
- FALSE, /* ignore content type */
- FALSE, /* use git diff format */
- svn_cmdline_output_encoding(pool),
- outfile,
- errfile,
- NULL,
- lb->ctx, pool);
- if (err)
- {
- /* We get a "path not found" error in case the revision created
- * lb->target_url. Try to show a diff from the parent instead. */
- if (err->apr_err == SVN_ERR_FS_NOT_FOUND)
- {
- const char *parent;
- apr_pool_t *iterpool;
-
- svn_error_clear(err);
-
- parent = svn_uri_dirname(lb->target_url, pool);
- iterpool = svn_pool_create(pool);
- while (strcmp(parent, lb->target_url) != 0)
- {
- svn_pool_clear(iterpool);
- err = svn_client_diff5(diff_options,
- parent,
- &start_revision,
- parent,
- &end_revision,
- NULL,
- lb->depth,
- FALSE, /* ignore ancestry */
- TRUE, /* no diff deleted */
- FALSE, /* show copies as adds */
- FALSE, /* ignore content type */
- FALSE, /* use git diff format */
- svn_cmdline_output_encoding(iterpool),
- outfile,
- errfile,
- NULL,
- lb->ctx, iterpool);
- if (err == SVN_NO_ERROR)
- break;
- else
- {
- if (err->apr_err == SVN_ERR_FS_NOT_FOUND)
- {
- svn_error_clear(err);
- parent = svn_uri_dirname(parent, pool);
- continue;
- }
- if (err->apr_err == SVN_ERR_RA_ILLEGAL_URL ||
- err->apr_err == SVN_ERR_AUTHZ_UNREADABLE ||
- err->apr_err == SVN_ERR_RA_LOCAL_REPOS_OPEN_FAILED)
- {
- svn_error_clear(err);
- break;
- }
- return svn_error_trace(err);
- }
- }
- svn_pool_destroy(iterpool);
- }
- else
- return svn_error_trace(err);
- }
-
+ SVN_ERR(svn_client_diff_peg5(diff_options,
+ lb->target_path_or_url,
+ &lb->target_peg_revision,
+ &start_revision, &end_revision,
+ NULL,
+ lb->depth,
+ FALSE, /* ignore ancestry */
+ TRUE, /* no diff deleted */
+ FALSE, /* show copies as adds */
+ FALSE, /* ignore content type */
+ FALSE, /* use git diff format */
+ svn_cmdline_output_encoding(pool),
+ outfile,
+ errfile,
+ NULL,
+ lb->ctx, pool));
SVN_ERR(svn_cmdline_printf(pool, _("\n")));
}
@@ -571,8 +511,6 @@ svn_cl__log(apr_getopt_t *os,
struct log_receiver_baton lb;
const char *target;
int i;
- svn_opt_revision_t peg_revision;
- const char *true_path;
apr_array_header_t *revprops;
if (!opt_state->xml)
@@ -626,8 +564,6 @@ svn_cl__log(apr_getopt_t *os,
/* Add "." if user passed 0 arguments */
svn_opt_push_implicit_dot_target(targets, pool);
- target = APR_ARRAY_IDX(targets, 0, const char *);
-
/* Determine if they really want a two-revision range. */
if (opt_state->used_change_arg)
{
@@ -649,9 +585,15 @@ svn_cl__log(apr_getopt_t *os,
}
}
- /* Strip peg revision. */
- SVN_ERR(svn_opt_parse_path(&peg_revision, &true_path, target, pool));
- APR_ARRAY_IDX(targets, 0, const char *) = true_path;
+ /* Parse the first target into path-or-url and peg revision. */
+ target = APR_ARRAY_IDX(targets, 0, const char *);
+ SVN_ERR(svn_opt_parse_path(&lb.target_peg_revision, &lb.target_path_or_url,
+ target, pool));
+ if (lb.target_peg_revision.kind == svn_opt_revision_unspecified)
+ lb.target_peg_revision.kind = (svn_path_is_url(target)
+ ? svn_opt_revision_head
+ : svn_opt_revision_working);
+ APR_ARRAY_IDX(targets, 0, const char *) = lb.target_path_or_url;
if (svn_path_is_url(target))
{
@@ -670,8 +612,6 @@ svn_cl__log(apr_getopt_t *os,
lb.ctx = ctx;
lb.omit_log_message = opt_state->quiet;
- SVN_ERR(svn_client_url_from_path2(&lb.target_url, true_path, ctx,
- pool, pool));
lb.show_diff = opt_state->show_diff;
lb.depth = opt_state->depth == svn_depth_unknown ? svn_depth_infinity
: opt_state->depth;
@@ -722,7 +662,7 @@ svn_cl__log(apr_getopt_t *os,
APR_ARRAY_PUSH(revprops, const char *) = SVN_PROP_REVISION_LOG;
}
SVN_ERR(svn_client_log5(targets,
- &peg_revision,
+ &lb.target_peg_revision,
opt_state->revision_ranges,
opt_state->limit,
opt_state->verbose,
@@ -745,7 +685,7 @@ svn_cl__log(apr_getopt_t *os,
if (!opt_state->quiet)
APR_ARRAY_PUSH(revprops, const char *) = SVN_PROP_REVISION_LOG;
SVN_ERR(svn_client_log5(targets,
- &peg_revision,
+ &lb.target_peg_revision,
opt_state->revision_ranges,
opt_state->limit,
opt_state->verbose,
Propchange: subversion/branches/1.7.x/subversion/tests/cmdline/basic_tests.py
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Feb 24 07:21:04 2012
@@ -10,6 +10,7 @@
/subversion/branches/1.7.x-r1159093/subversion/tests/cmdline/basic_tests.py:1159097-1159230
/subversion/branches/1.7.x-r1163557/subversion/tests/cmdline/basic_tests.py:1163574-1170648
/subversion/branches/1.7.x-r1173425/subversion/tests/cmdline/basic_tests.py:1173429-1176454
+/subversion/branches/1.7.x-r1210147/subversion/tests/cmdline/basic_tests.py:1213310-1293110
/subversion/branches/atomic-revprop/subversion/tests/cmdline/basic_tests.py:965046-1000689
/subversion/branches/bdb-reverse-deltas/subversion/tests/cmdline/basic_tests.py:872050-872529
/subversion/branches/diff-callbacks3/subversion/tests/cmdline/basic_tests.py:870059-870761
Modified: subversion/branches/1.7.x/subversion/tests/cmdline/diff_tests.py
URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/subversion/tests/cmdline/diff_tests.py?rev=1293111&r1=1293110&r2=1293111&view=diff
==============================================================================
--- subversion/branches/1.7.x/subversion/tests/cmdline/diff_tests.py (original)
+++ subversion/branches/1.7.x/subversion/tests/cmdline/diff_tests.py Fri Feb 24 07:21:04 2012
@@ -57,6 +57,16 @@ def make_diff_header(path, old_tag, new_
"+++ " + path_as_shown + "\t(" + new_tag + ")\n",
]
+def make_no_diff_deleted_header(path, old_tag, new_tag):
+ """Generate the expected diff header for a deleted file PATH when in
+ 'no-diff-deleted' mode. (In that mode, no further details appear after the
+ header.) Return the header as an array of newline-terminated strings."""
+ path_as_shown = path.replace('\\', '/')
+ return [
+ "Index: " + path_as_shown + " (deleted)\n",
+ "===================================================================\n",
+ ]
+
def make_git_diff_header(target_path, repos_relpath,
old_tag, new_tag, add=False, src_label=None,
dst_label=None, delete=False, text_changes=True,
Modified: subversion/branches/1.7.x/subversion/tests/cmdline/log_tests.py
URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/subversion/tests/cmdline/log_tests.py?rev=1293111&r1=1293110&r2=1293111&view=diff
==============================================================================
--- subversion/branches/1.7.x/subversion/tests/cmdline/log_tests.py (original)
+++ subversion/branches/1.7.x/subversion/tests/cmdline/log_tests.py Fri Feb 24 07:21:04 2012
@@ -34,6 +34,7 @@ from svntest import wc
from svntest.main import server_has_mergeinfo
from svntest.main import SVN_PROP_MERGEINFO
from merge_tests import set_up_branch
+from diff_tests import make_diff_header, make_no_diff_deleted_header
# (abbreviation)
Skip = svntest.testcase.Skip_deco
@@ -178,7 +179,8 @@ def guarantee_repos_and_wc(sbox):
to test the code"""
svntest.main.file_write(msg_file, msg)
svntest.main.file_append(iota_path, "8")
- svntest.main.file_append(rho_path, "8")
+ svntest.main.file_append(rho_path, "88") # More than one char so libmagic
+ # treats it as text.
svntest.main.run_svn(None, 'add', rho_path)
svntest.main.run_svn(None,
'ci', '-F', msg_file)
@@ -424,7 +426,7 @@ class SVNLogParseError(Exception):
pass
-def parse_log_output(log_lines):
+def parse_log_output(log_lines, with_diffs=False):
"""Return a log chain derived from LOG_LINES.
A log chain is a list of hashes; each hash represents one log
message, in the order it appears in LOG_LINES (the first log
@@ -438,6 +440,7 @@ def parse_log_output(log_lines):
'date' ===> string
'msg' ===> string (the log message itself)
'lines' ===> number (so that it may be checked against rev)
+
If LOG_LINES contains changed-path information, then the hash
also contains
@@ -451,7 +454,11 @@ def parse_log_output(log_lines):
'reverse_merges' ===> list of reverse-merging revisions that resulted
in this log being part of the list of messages.
- """
+
+ If LOG_LINES contains diffs and WITH_DIFFS=True, then the hash also contains
+
+ 'diff_lines' ===> list of strings (diffs)
+ """
# Here's some log output to look at while writing this function:
@@ -566,6 +573,20 @@ def parse_log_output(log_lines):
for line in log_lines[0:lines]:
msg += line
del log_lines[0:lines]
+
+ # Maybe accumulate a diff.
+ # If there is a diff, there is a blank line before and after it.
+ if with_diffs and len(log_lines) >= 2 and log_lines[0] == '\n':
+ log_lines.pop(0)
+ diff_lines = []
+ while len(log_lines) and log_lines[0] != msg_separator:
+ diff_lines.append(log_lines.pop(0))
+ if diff_lines[-1] == '\n':
+ diff_lines.pop()
+ else:
+ raise SVNLogParseError("no blank line after diff in log")
+ this_item['diff_lines'] = diff_lines
+
elif this_line == msg_separator:
if this_item:
this_item['msg'] = msg
@@ -2028,6 +2049,59 @@ def log_on_nonexistent_path_and_valid_re
svntest.actions.run_and_verify_svn(None, None, expected_error,
'log', '-q', bad_path_default_rev)
+#----------------------------------------------------------------------
+def log_diff(sbox):
+ "'svn log --diff'"
+
+ guarantee_repos_and_wc(sbox)
+
+ was_cwd = os.getcwd()
+ os.chdir(sbox.wc_dir)
+
+ exit_code, output, err = svntest.actions.run_and_verify_svn(None, None, [],
+ 'log', '--diff')
+ os.chdir(was_cwd)
+
+ for line in output:
+ if line.startswith('Index:'):
+ break
+ else:
+ raise SVNLogParseError("no diffs found in log output")
+
+ # After a copy, a log of the copy destination used to fail because the
+ # diff tried to use the head-revision URL with the old revision numbers
+ # without using the correct peg revision.
+
+ sbox.simple_copy('A', 'A2')
+ sbox.simple_commit()
+
+ os.chdir(sbox.wc_dir)
+ exit_code, output, err = svntest.actions.run_and_verify_svn(None, None, [],
+ 'log', '--diff',
+ '-r10:8', 'A2')
+ os.chdir(was_cwd)
+
+ r9diff = make_no_diff_deleted_header('A2/B/E/alpha', 8, 9) \
+ + make_diff_header('A2/B/E/beta', 'revision 8', 'revision 9') \
+ + [ "@@ -1 +1,2 @@\n",
+ " This is the file 'beta'.\n",
+ "+9\n",
+ "\ No newline at end of file\n",
+ ]
+ r8diff = make_diff_header('A2/D/G/rho', 'revision 0', 'revision 8') \
+ + [ "@@ -0,0 +1 @@\n",
+ "+88\n",
+ "\ No newline at end of file\n",
+ ]
+ log_chain = parse_log_output(output, with_diffs=True)
+ if len(log_chain) != 3:
+ raise SVNLogParseError("%d logs found, 3 expected" % len(log_chain))
+ svntest.verify.compare_and_display_lines(None, "diff for r9",
+ r9diff, log_chain[1]['diff_lines'])
+ svntest.verify.compare_and_display_lines(None, "diff for r8",
+ r8diff, log_chain[2]['diff_lines'])
+
+
########################################################################
# Run the tests
@@ -2067,6 +2141,7 @@ test_list = [ None,
merge_sensitive_log_ignores_cyclic_merges,
log_with_unrelated_peg_and_operative_revs,
log_on_nonexistent_path_and_valid_rev,
+ log_diff,
]
if __name__ == '__main__':