You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/08/22 18:22:46 UTC
[GitHub] storm pull request #2290: [STORM-2703] Handle ExecutionException in handleWa...
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2290
[STORM-2703] Handle ExecutionException in handleWaitingForBlobLocalization state
See: https://issues.apache.org/jira/browse/STORM-2703
Keep supervisor from crashing when exception happens because of blob permission exception (or KeyNotFound exception). The code change here will bring state machine back to `MachineState.EMPTY` when that happens and start over.
So, if the blob ACL permission is fixed (or the key is uploaded) during the runtime, the topology will start to work; if the topology is killed, the Slot is able to continue to deal with other assignment.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ethanlm/storm STORM-2703
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2290
----
commit 3213ba40b9479337e8f9dc1c412f57e6bb57aace
Author: Ethan Li <et...@gmail.com>
Date: 2017-08-22T18:15:30Z
[STORM-2703] Handle ExecutionException in handleWaitingForBlobLocalization state
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2290: [STORM-2703] Handle ExecutionException in handleWaitingFo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2290
+1 Nice finding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2290: [STORM-2703] Handle ExecutionException in handleWa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2290: [STORM-2703] Handle ExecutionException in handleWaitingFo...
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2290
Tested it manually.
1. Create a blob `key1` with ACL set to `u:mapredqa:rwa`.
2. Submit a topology as `ethan` with `-c topology.blobstore.map='{"key1":{"localname":"test-blob.txt", "uncompress":false}}'`.
3. Check the supervisor.log: `[ethan] does not have access no key1`. And the slot changed to `EMPTY` state. The supervisor didn't crash.
4. Later, set the blob `key1` ACL with command `set-acl -s u:ethan:rwa key1`
5. Check the supervisor.log. The workers started running. Also checked with worker.log which showed normal outputs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---