You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/29 04:05:03 UTC

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #19094: [feat][admin] PIP-219 Part-1 Add admin API for trimming topic

gaoran10 commented on code in PR #19094:
URL: https://github.com/apache/pulsar/pull/19094#discussion_r1058716685


##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java:
##########
@@ -1145,6 +1145,18 @@ public CompletableFuture<Void> triggerCompactionAsync(String topic) {
         return asyncPutRequest(path, Entity.entity("", MediaType.APPLICATION_JSON));
     }
 
+    @Override
+    public void trimTopic(String topic) throws PulsarAdminException {
+        sync(() -> triggerCompactionAsync(topic));

Review Comment:
   Maybe trimTopicAsync?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org