You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Alex Parvulescu <al...@gmail.com> on 2012/04/24 14:54:16 UTC
logging
Hi,
Running the tests I noticed that oak-jcr is missing a logging
implementation for the tests:
Running org.apache.jackrabbit.oak.jcr.RepositoryTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
So looking at the logging dependencies in more detail:
- oak-core: slf4j-api, jcl-over-slf4j, logback-classic
1.0.0 as an impl for tests
- oak-it/jcr & oak-it/mk:
logback-classic 1.0.1 as an impl for tests
- oak-jcr: slf4j-api, jcl-over-slf4j, missing
logging implementation for tests:
Suggestions
- as far as I see the jcl-over-slf4j is unused, so it can be dropped from
oak-core and oak-jcr.
- add a logging impl to the oak-jcr tests
- there should be one version of logback-classic in use, probably 1.0.1
I can create an issue and take care of this, if it's not already on
somebody's radar.
thanks,
alex
Re: logging
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Tue, Apr 24, 2012 at 2:54 PM, Alex Parvulescu
<al...@gmail.com> wrote:
> - as far as I see the jcl-over-slf4j is unused, so it can be dropped from
> oak-core and oak-jcr.
jcl-over-slf4j maps the Commons Logging interfaces to SLF4J. IIRC at
least some of our dependencies needed Commons Logging, which is why
jcl-over-slf4j was needed.
See also my note in OAK-71 about oak-run where the logging
implementation is needed also outside the context of test cases.
BR,
Jukka Zitting
Re: logging
Posted by Michael Dürig <md...@apache.org>.
On 24.4.12 14:54, Alex Parvulescu wrote:
> Hi,
>
> Running the tests I noticed that oak-jcr is missing a logging
> implementation for the tests:
> Running org.apache.jackrabbit.oak.jcr.RepositoryTest
> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
> SLF4J: Defaulting to no-operation (NOP) logger implementation
> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
> details.
>
> So looking at the logging dependencies in more detail:
> - oak-core: slf4j-api, jcl-over-slf4j, logback-classic
> 1.0.0 as an impl for tests
> - oak-it/jcr& oak-it/mk:
> logback-classic 1.0.1 as an impl for tests
> - oak-jcr: slf4j-api, jcl-over-slf4j, missing
> logging implementation for tests:
>
> Suggestions
> - as far as I see the jcl-over-slf4j is unused, so it can be dropped from
> oak-core and oak-jcr.
> - add a logging impl to the oak-jcr tests
> - there should be one version of logback-classic in use, probably 1.0.1
>
> I can create an issue and take care of this, if it's not already on
> somebody's radar.
Yes, that's be great!
Michael
>
> thanks,
> alex
>