You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/25 01:02:46 UTC
[GitHub] [pulsar] devinbost opened a new pull request #11084: Added count to OpReadEntry.recycle()
devinbost opened a new pull request #11084:
URL: https://github.com/apache/pulsar/pull/11084
While exploring a heap dump, I noticed that recycled OpReadEntry instances still had > 0 count values.
This PR adds the count to recycle() to ensure the count gets reset to 0. It's not clear what the impact may be at this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #11084: Added count to OpReadEntry.recycle()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11084:
URL: https://github.com/apache/pulsar/pull/11084#issuecomment-1058889060
@devinbost:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #11084: Added count to OpReadEntry.recycle()
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #11084:
URL: https://github.com/apache/pulsar/pull/11084#issuecomment-1058888915
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] devinbost commented on pull request #11084: Added count to OpReadEntry.recycle()
Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #11084:
URL: https://github.com/apache/pulsar/pull/11084#issuecomment-868106308
@lhotari @merlimat @eolivelli thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org