[GitHub] graceguo-supercat commented on a change in pull request #4941: Add separate limit setting for SqlLab

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #4941: Add separate limit setting for SqlLab
URL: https://github.com/apache/incubator-superset/pull/4941#discussion_r231678388
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -282,8 +282,8 @@
 # in the results backend. This also becomes the limit when exporting CSVs
 SQL_MAX_ROW = 100000
 
-# Limit to be returned to the frontend.
-DISPLAY_MAX_ROW = 1000
+# Default row limit for SQL Lab queries
+DEFAULT_SQLLAB_LIMIT = 10000
 
 Review comment:
   @mistercrunch Sql Lab used to only render 1000 rows for each query, but fetch a much bigger number of rows of results. Do you have any suggestion on this default query limit number?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org