You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/08 14:50:25 UTC
[GitHub] [dubbo-samples] wzg547228197 opened a new pull request #236: add case-configuration in dubbo-samples-nacos-router
wzg547228197 opened a new pull request #236:
URL: https://github.com/apache/dubbo-samples/pull/236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #236: add case-configuration in dubbo-samples-nacos-router
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #236:
URL: https://github.com/apache/dubbo-samples/pull/236#discussion_r554002147
##########
File path: dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/src/main/resources/spring/dubbo-demo-provider.xml
##########
@@ -29,7 +29,8 @@
<dubbo:registry address="nacos://${nacos.address:127.0.0.1}:8848"/>
- <dubbo:protocol port="${dubbo.port:20880}"/>
+ <dubbo:protocol name="dubbo" port="20880" heartbeat="10000"/>
+ <dubbo:protocol name="dubbo" port="20881" heartbeat="10000"/>
Review comment:
原来没有暴露20881端口？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj merged pull request #236: add case-configuration in dubbo-samples-nacos-router
Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #236:
URL: https://github.com/apache/dubbo-samples/pull/236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] wzg547228197 commented on a change in pull request #236: add case-configuration in dubbo-samples-nacos-router
Posted by GitBox <gi...@apache.org>.
wzg547228197 commented on a change in pull request #236:
URL: https://github.com/apache/dubbo-samples/pull/236#discussion_r554009427
##########
File path: dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/src/main/resources/spring/dubbo-demo-provider.xml
##########
@@ -29,7 +29,8 @@
<dubbo:registry address="nacos://${nacos.address:127.0.0.1}:8848"/>
- <dubbo:protocol port="${dubbo.port:20880}"/>
+ <dubbo:protocol name="dubbo" port="20880" heartbeat="10000"/>
+ <dubbo:protocol name="dubbo" port="20881" heartbeat="10000"/>
Review comment:
对，原来的provider.xml配置只有20880，但我看pom.xml里两个端口都配置了
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #236: add case-configuration in dubbo-samples-nacos-router
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #236:
URL: https://github.com/apache/dubbo-samples/pull/236#discussion_r554012485
##########
File path: dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/src/main/resources/spring/dubbo-demo-provider.xml
##########
@@ -29,7 +29,8 @@
<dubbo:registry address="nacos://${nacos.address:127.0.0.1}:8848"/>
- <dubbo:protocol port="${dubbo.port:20880}"/>
+ <dubbo:protocol name="dubbo" port="20880" heartbeat="10000"/>
+ <dubbo:protocol name="dubbo" port="20881" heartbeat="10000"/>
Review comment:
我看了一下pom.xml的容器配置，原来启动了两个provider容器，指定不同的端口，现在改成一个容器中启动两个端口，应该改为原来的方式吧？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] wzg547228197 commented on a change in pull request #236: add case-configuration in dubbo-samples-nacos-router
Posted by GitBox <gi...@apache.org>.
wzg547228197 commented on a change in pull request #236:
URL: https://github.com/apache/dubbo-samples/pull/236#discussion_r554009427
##########
File path: dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/src/main/resources/spring/dubbo-demo-provider.xml
##########
@@ -29,7 +29,8 @@
<dubbo:registry address="nacos://${nacos.address:127.0.0.1}:8848"/>
- <dubbo:protocol port="${dubbo.port:20880}"/>
+ <dubbo:protocol name="dubbo" port="20880" heartbeat="10000"/>
+ <dubbo:protocol name="dubbo" port="20881" heartbeat="10000"/>
Review comment:
对，原来的provider.xml配置只有20880，但我看pom.xml里两个端口都配置了
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #236: add case-configuration in dubbo-samples-nacos-router
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #236:
URL: https://github.com/apache/dubbo-samples/pull/236#discussion_r554002147
##########
File path: dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/src/main/resources/spring/dubbo-demo-provider.xml
##########
@@ -29,7 +29,8 @@
<dubbo:registry address="nacos://${nacos.address:127.0.0.1}:8848"/>
- <dubbo:protocol port="${dubbo.port:20880}"/>
+ <dubbo:protocol name="dubbo" port="20880" heartbeat="10000"/>
+ <dubbo:protocol name="dubbo" port="20881" heartbeat="10000"/>
Review comment:
原来没有暴露20881端口？
##########
File path: dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter/src/main/resources/spring/dubbo-demo-provider.xml
##########
@@ -29,7 +29,8 @@
<dubbo:registry address="nacos://${nacos.address:127.0.0.1}:8848"/>
- <dubbo:protocol port="${dubbo.port:20880}"/>
+ <dubbo:protocol name="dubbo" port="20880" heartbeat="10000"/>
+ <dubbo:protocol name="dubbo" port="20881" heartbeat="10000"/>
Review comment:
我看了一下pom.xml的容器配置，原来启动了两个provider容器，指定不同的端口，现在改成一个容器中启动两个端口，应该改为原来的方式吧？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org