You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "cmcfarlen (via GitHub)" <gi...@apache.org> on 2025/10/18 02:07:42 UTC
[PR] Remove eventsystem Inline.cc and cleanup private headers. [trafficserver]
cmcfarlen opened a new pull request, #12581:
URL: https://github.com/apache/trafficserver/pull/12581
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove eventsystem Inline.cc and cleanup private headers. [trafficserver]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #12581:
URL: https://github.com/apache/trafficserver/pull/12581#discussion_r2467233117
##########
src/iocore/utils/OneWayMultiTunnel.cc:
##########
@@ -45,6 +44,18 @@ OneWayMultiTunnel::OneWayMultiTunnel() : OneWayTunnel()
ink_zero(vioTargets);
}
+VIO *
+vc_do_io_write(VConnection *vc, Continuation *cont, int64_t nbytes, MIOBuffer *buf, int64_t offset)
+{
+ IOBufferReader *reader = buf->alloc_reader();
+
+ if (offset > 0) {
+ reader->consume(offset);
+ }
+
+ return vc->do_io_write(cont, nbytes, reader, true);
+}
Review Comment:
This function `vc_do_io_write` appears to be duplicated from the removed `P_VConnection.h`. Consider whether this should be moved to a shared location or if it's intentionally file-specific. The same implementation was in the deleted header file, suggesting it might be used elsewhere.
##########
src/iocore/eventsystem/UnixEThread.cc:
##########
@@ -52,7 +54,8 @@ char const *const EThread::Metrics::Slice::STAT_NAME[] = {
"proxy.process.eventloop.io.wait.max", "proxy.process.eventloop.io.work.max",
};
-int thread_max_heartbeat_mseconds = THREAD_MAX_HEARTBEAT_MSECONDS;
+int thread_max_heartbeat_mseconds = THREAD_MAX_HEARTBEAT_MSECONDS;
+const ink_hrtime DELAY_FOR_RETRY = HRTIME_MSECONDS(10);
Review Comment:
The constant `DELAY_FOR_RETRY` is being defined here but was previously in `P_UnixEThread.h`. If this constant is used in other translation units, this change could cause linker errors due to multiple definitions, or undefined references if those files haven't been updated to include the necessary declaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove eventsystem Inline.cc and cleanup private headers. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen merged PR #12581:
URL: https://github.com/apache/trafficserver/pull/12581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove eventsystem Inline.cc and cleanup private headers. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #12581:
URL: https://github.com/apache/trafficserver/pull/12581#issuecomment-3509083542
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove eventsystem Inline.cc and cleanup private headers. [trafficserver]
Posted by "moonchen (via GitHub)" <gi...@apache.org>.
moonchen commented on code in PR #12581:
URL: https://github.com/apache/trafficserver/pull/12581#discussion_r2504734218
##########
include/iocore/eventsystem/VConnection.h:
##########
Review Comment:
InkAPIPrivateIOCore.h includes this header and not VIO.h, so any file that includes only InkAPIPrivateIOCore.h will now have an `#error`. I think this preprocessor directive should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove eventsystem Inline.cc and cleanup private headers. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #12581:
URL: https://github.com/apache/trafficserver/pull/12581#issuecomment-3509082270
> Inline.cc needs to be removed from src/iocore/net/CMakeLists.txt.
I don't see `Inline.cc` in any `CMakeLists.txt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove eventsystem Inline.cc and cleanup private headers. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #12581:
URL: https://github.com/apache/trafficserver/pull/12581#issuecomment-3423867784
There is one issue with this PR where Continuation.h externs `this_ethread` but it's inlined in `EThread.h`. See https://github.com/apache/trafficserver/commit/f590e4ec977fb1db70580c3979a900c5802d1c8e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org