You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hiboyang (via GitHub)" <gi...@apache.org> on 2024/04/22 23:33:55 UTC
[PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
hiboyang opened a new pull request, #19:
URL: https://github.com/apache/spark-connect-go/pull/19
### What changes were proposed in this pull request?
Use v1 for this Spark Connect Go Client library, instead of previously using v34.
### Why are the changes needed?
There is a recent discussion in Spark community for Spark Operator version naming convention. People like to use version independent of Spark versions. That applies to Spark Connect Go Client as well. Thus change the version here to start from v1.
### Does this PR introduce _any_ user-facing change?
Yes, Spark Connect Go Client users will use v1 instead of use v34.
### How was this patch tested?
Run unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47842][CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2078384187
@hiboyang is this https://issues.apache.org/jira/browse/SPARK-47842 correct? you should create a new JIRA, and link it to PR title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2075558029
maybe cc @HyukjinKwon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1575690071
##########
go.mod:
##########
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-module github.com/apache/spark-connect-go/v34
+module github.com/apache/spark-connect-go/v1
Review Comment:
Is this entry point which defines the version for this go library?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2071485404
> Use v1 for this Spark Connect Go Client library, instead of previously using v34.
For Spart K8s operator, we begin with 0.1.0 as the first release version as discussion in mailing list.
For the v1 and v34 versions here, I'm not sure about if it is same case. Do you already have v34 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1575692381
##########
go.mod:
##########
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-module github.com/apache/spark-connect-go/v34
+module github.com/apache/spark-connect-go/v1
Review Comment:
I guess this `v34` is accumulated since this go library began. Is it the same as the release version? I'm not sure if it is okay to change it like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] [SPARK-47842] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2075911147
Thanks @viirya for the review!
@HyukjinKwon @grundprinzip do you get time to look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2073580127
> Does this Spark connect go library have any previous release yet?
No release previously. For GoLang repo, people can just import the repo directly. Thus such "releasing" is actually not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1578325614
##########
internal/generated/expressions.pb.go:
##########
@@ -211,6 +211,7 @@ type Expression struct {
// *Expression_UpdateFields_
// *Expression_UnresolvedNamedLambdaVariable_
// *Expression_CommonInlineUserDefinedFunction
+ // *Expression_CallFunction
Review Comment:
I know this is generated, but is it intentional change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47842][CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2077771410
Thanks @HyukjinKwon @grundprinzip for reviewing! Would you help to merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1576977935
##########
go.mod:
##########
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-module github.com/apache/spark-connect-go/v34
+module github.com/apache/spark-connect-go/v1
Review Comment:
Previously we use `v34` to make it align with Spark 3.4 at that time. It is not accumulated version number. Things will still work after changing `v34` to `v1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47842][CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #19: [SPARK-47842][CONNECT] Use v1 as spark connect go library starting version
URL: https://github.com/apache/spark-connect-go/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2075513386
Yeah, Go module name normally put `v2`/`v3`/etc in the end to indicate major version bump, like `module example.com/mymodule/v2`, see example in the end of https://go.dev/doc/modules/version-numbers. Kind of different convention from JVM packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47978][CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "ptxmac (via GitHub)" <gi...@apache.org>.
ptxmac commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2205937210
Fun fact, you can't have `v1` of go libraries ðŸ«
They must either have no version, or at least be version 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2073588176
> > Use v1 for this Spark Connect Go Client library, instead of previously using v34.
>
> For Spart K8s operator, we begin with 0.1.0 as the first release version as discussion in mailing list.
>
> For the v1 and v34 versions here, I'm not sure about if it is same case. Do you already have v34 release?
Hmm... feel there is some confusion with the meaning of `v1` and `v34` here. `v34` is part of Go module name like `github.com/apache/spark-connect-go/v34`. It is not a release. Due to the recent discussion, we want to decouple the versioning of this project from Spark versioning. Thus modify the module name from `github.com/apache/spark-connect-go/v34` to `github.com/apache/spark-connect-go/v1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2073619182
Got it. I didn't know the actual meaning of `v34` so I thought that you had v1, v2, ...v34 before.
I am also not sure why the version number is embedded into the Go module name. Is it a common practice seen on other Go modules too? So once this Go library has v2 release, you will go to increase `v1` to `v2` in the module name again?
I am not familiar with how Go module naming policy. I try to compare this with JVM package name and release version. For example, we don't have 3.4 in Spark JVM package name actually.
So I'm wondering if it makes sense to remove the version number `v34` from this Go module name? 🤔
Of course it is commonly seen in other Go modules, then it is okay to rename it from `v34` to `v1`.
It is also better to let other contributors of this Go library to take a look too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47842][CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2078381967
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1578326225
##########
go.mod:
##########
@@ -49,10 +49,10 @@ require (
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/zeebo/xxh3 v1.0.2 // indirect
golang.org/x/mod v0.10.0 // indirect
- golang.org/x/net v0.10.0 // indirect
+ golang.org/x/net v0.17.0 // indirect
golang.org/x/oauth2 v0.8.0
- golang.org/x/sys v0.8.0 // indirect
- golang.org/x/text v0.9.0 // indirect
+ golang.org/x/sys v0.13.0 // indirect
+ golang.org/x/text v0.13.0 // indirect
Review Comment:
Did you also upgrade these libraries in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1578324700
##########
client/sql/dataframe.go:
##########
@@ -23,7 +23,7 @@ import (
"github.com/apache/arrow/go/v12/arrow"
"github.com/apache/arrow/go/v12/arrow/array"
"github.com/apache/arrow/go/v12/arrow/ipc"
- proto "github.com/apache/spark-connect-go/v34/internal/generated"
+ proto "github.com/apache/spark-connect-go/v1/internal/generated"
Review Comment:
Oh, okay, I see. I saw the above arrow go libraries also have version number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] [SPARK-47842] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2075909571
> Do we need to create JIRA ticket for this? @hiboyang
Created JIRA just now: https://issues.apache.org/jira/projects/SPARK/issues/SPARK-47842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] [SPARK-47842] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1578561266
##########
go.mod:
##########
@@ -49,10 +49,10 @@ require (
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/zeebo/xxh3 v1.0.2 // indirect
golang.org/x/mod v0.10.0 // indirect
- golang.org/x/net v0.10.0 // indirect
+ golang.org/x/net v0.17.0 // indirect
golang.org/x/oauth2 v0.8.0
- golang.org/x/sys v0.8.0 // indirect
- golang.org/x/text v0.9.0 // indirect
+ golang.org/x/sys v0.13.0 // indirect
+ golang.org/x/text v0.13.0 // indirect
Review Comment:
I did not update these intentionally. Seems caused by Go automatically. Looks not hurting (also may be better) to use these new versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] [SPARK-47842] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1578559424
##########
internal/generated/expressions.pb.go:
##########
@@ -211,6 +211,7 @@ type Expression struct {
// *Expression_UpdateFields_
// *Expression_UnresolvedNamedLambdaVariable_
// *Expression_CommonInlineUserDefinedFunction
+ // *Expression_CallFunction
Review Comment:
This is generated and better to keep the change so the generated code is fully compatible with the protobuf protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2075559200
Do we need to create JIRA ticket for this? @hiboyang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47978][CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2078602810
> @hiboyang is this https://issues.apache.org/jira/browse/SPARK-47842 correct? you should create a new JIRA, and link it to PR title.
Oops, should be this one: [SPARK-47978](https://issues.apache.org/jira/browse/SPARK-47978). I updated this PR title with correct one.
Thanks for merging the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [CONNECT] Use v1 as spark connect go library starting version [spark-connect-go]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2071185132
Does this Spark connect go library have any previous release yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org