[GitHub] orc pull request #115: ORC-183: Add a method in Type to build type

[omalley <gi...@git.apache.org>]

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/115#discussion_r114603588
  
    --- Diff: c++/src/TypeImpl.cc ---
    @@ -491,4 +491,190 @@ namespace orc {
         return std::unique_ptr<Type>(result);
       }
     
    +  Type * Type::buildTypeFromString(const std::string& input) {
    --- End diff --
    
    This should probably be factored in to smaller functions. Take a look at the equivalent java https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/TypeDescription.java#L396 and you'll see parseName, parseCategory, parseInteger, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---