You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/19 05:22:19 UTC

[GitHub] [apisix] tzssangglass commented on a diff in pull request #7079: feat(ops): check dns resolver address is valid

tzssangglass commented on code in PR #7079:
URL: https://github.com/apache/apisix/pull/7079#discussion_r876603774


##########
apisix/cli/ops.lua:
##########
@@ -602,6 +602,10 @@ Please modify "admin_key" in conf/config.yaml .
     end
 
     for i, r in ipairs(sys_conf["dns_resolver"]) do
+        local res, err = cli_ip.valid(r)
+        if not res then
+            util.die("invalid dns resolver address: ", r,  ", err: ", err)

Review Comment:
   agree, fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org