You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/05/15 16:40:00 UTC
Review Request 21487: CLOUDSTACK-6687: Fixed IP reservation test case
failures with code re-factoring
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21487/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-6687
https://issues.apache.org/jira/browse/CLOUDSTACK-6687
Repository: cloudstack-git
Description
-------
Fixed the failures in TestFailureScenarios test suite with code-refactoring.
Also handled case where error code 530 is thrown from server in the response instead of exception.
Working on making this change in all required files, will put up new patch for that.
Diffs
-----
test/integration/component/test_ip_reservation.py 390a959
tools/marvin/marvin/codes.py ef49c0c
tools/marvin/marvin/lib/common.py ad79588
Diff: https://reviews.apache.org/r/21487/diff/
Testing
-------
Yes.
Thanks,
Gaurav Aradhye
Re: Review Request 21487: CLOUDSTACK-6687: Fixed IP reservation test case
failures with code re-factoring
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21487/#review43341
-----------------------------------------------------------
Commit de9909403eaaa01d5b6fb6df631aceb4651a5422 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=de99094 ]
CLOUDSTACK-6687: Fixed IP reservation test case failures with code re-factoring
- ASF Subversion and Git Services
On May 19, 2014, 7:39 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21487/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 7:39 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-6687
> https://issues.apache.org/jira/browse/CLOUDSTACK-6687
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed the failures in TestFailureScenarios test suite with code-refactoring.
> Also handled case where error code 530 is thrown from server in the response instead of exception.
> Working on making this change in all required files, will put up new patch for that.
>
>
> Diffs
> -----
>
> test/integration/component/test_ip_reservation.py 390a959
> tools/marvin/marvin/codes.py ef49c0c
> tools/marvin/marvin/lib/common.py ad79588
>
> Diff: https://reviews.apache.org/r/21487/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> File Attachments
> ----------------
>
> 0001-CLOUDSTACK-6687-Fixed-IP-reservation-test-case-failu.patch
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0a3f2fba-cd4a-4312-8178-8727ffd2618c__0001-CLOUDSTACK-6687-Fixed-IP-reservation-test-case-failu.patch
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21487: CLOUDSTACK-6687: Fixed IP reservation test case
failures with code re-factoring
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21487/
-----------------------------------------------------------
(Updated May 19, 2014, 1:09 p.m.)
Review request for cloudstack and Girish Shilamkar.
Changes
-------
Adding rebased patch against master.
Bugs: CLOUDSTACK-6687
https://issues.apache.org/jira/browse/CLOUDSTACK-6687
Repository: cloudstack-git
Description
-------
Fixed the failures in TestFailureScenarios test suite with code-refactoring.
Also handled case where error code 530 is thrown from server in the response instead of exception.
Working on making this change in all required files, will put up new patch for that.
Diffs
-----
test/integration/component/test_ip_reservation.py 390a959
tools/marvin/marvin/codes.py ef49c0c
tools/marvin/marvin/lib/common.py ad79588
Diff: https://reviews.apache.org/r/21487/diff/
Testing
-------
Yes.
File Attachments (updated)
----------------
0001-CLOUDSTACK-6687-Fixed-IP-reservation-test-case-failu.patch
https://reviews.apache.org/media/uploaded/files/2014/05/19/0a3f2fba-cd4a-4312-8178-8727ffd2618c__0001-CLOUDSTACK-6687-Fixed-IP-reservation-test-case-failu.patch
Thanks,
Gaurav Aradhye
Re: Review Request 21487: CLOUDSTACK-6687: Fixed IP reservation test case
failures with code re-factoring
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21487/#review43114
-----------------------------------------------------------
Commit 77460e9556f7d1b9d6cac6c8ece199bf3b83cd9c in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=77460e9 ]
CLOUDSTACK-6687: Fixed IP reservation test case failures with code re-factoring
- ASF Subversion and Git Services
On May 15, 2014, 2:39 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21487/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 2:39 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-6687
> https://issues.apache.org/jira/browse/CLOUDSTACK-6687
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed the failures in TestFailureScenarios test suite with code-refactoring.
> Also handled case where error code 530 is thrown from server in the response instead of exception.
> Working on making this change in all required files, will put up new patch for that.
>
>
> Diffs
> -----
>
> test/integration/component/test_ip_reservation.py 390a959
> tools/marvin/marvin/codes.py ef49c0c
> tools/marvin/marvin/lib/common.py ad79588
>
> Diff: https://reviews.apache.org/r/21487/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>