You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Gimini-3 (via GitHub)" <gi...@apache.org> on 2026/09/20 02:19:11 UTC
[PR] Preserve numeric identity when merging heterogeneous sharding conditions [shardingsphere]
Gimini-3 opened a new pull request, #39902:
URL: https://github.com/apache/shardingsphere/pull/39902
Changes proposed in this pull request:
- Preserve exact integral values when converting sharding values to `BigDecimal`.
- Compare heterogeneous numeric sharding conditions by numeric identity, independent of Java type order and `BigDecimal` scale.
- Add unit coverage and a PostgreSQL Proxy prepared-parameter E2E case for `Long` and `BigDecimal` values above `2^53`.
Verification:
- Core unit tests: 109 tests, 0 failures, 0 errors.
- Spotless and Checkstyle passed for `features/sharding/core`, `test/e2e/fixture`, and `test/e2e/sql`.
- PostgreSQL Proxy Cluster E2E: 534 tests, 0 failures, 0 errors; the new PLACEHOLDER case passed through both query execution APIs.
AI assistance disclosure:
- Codex materially assisted with the sharding numeric conversion and condition-merging implementation, corresponding unit tests, and the PostgreSQL Proxy E2E fixture and case. The resulting seven-file diff was self-reviewed and verified locally.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed the full repository maven check locally; scoped unit, style, and Proxy E2E checks are listed above.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version.
- [x] I have disclosed the tool and affected files or scope for material AI assistance, as required by the [AI-assisted contribution policy](https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve numeric identity when merging heterogeneous sharding conditions [shardingsphere]
Posted by "Gimini-3 (via GitHub)" <gi...@apache.org>.
Gimini-3 commented on PR #39902:
URL: https://github.com/apache/shardingsphere/pull/39902#issuecomment-5755119035
Addressed the remaining high-frequency-path feedback in `5be5ab1a1e8`.
- Replaced all Stream predicates and the capturing collection lambdas in numeric merging with explicit loops.
- Kept heterogeneous numeric normalization once per collection.
- Marked `mergeListShardingValues` with `@HighFrequencyInvocation`, the smallest scope that owns this high-frequency work.
- Re-ran the focused core tests: 117 passed with zero failures or errors.
- Re-ran `spotless:check` and `checkstyle:check` for `features/sharding/core`: both passed.
The intersection behavior remains unchanged for empty, homogeneous, heterogeneous, finite, and infinite numeric inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve numeric identity when merging heterogeneous sharding conditions [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39902:
URL: https://github.com/apache/shardingsphere/pull/39902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org