You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/23 11:04:12 UTC

[GitHub] [apisix-website] iamayushdas opened a new pull request #349: feat: Announcement bar added for new release

iamayushdas opened a new pull request #349:
URL: https://github.com/apache/apisix-website/pull/349


   Changes:
   added a feature - announcement bar whih will notify users for new releases and after some days we can use next announcement for join slack channel
   
   Screenshots of the change:
   ![announcemnet](https://user-images.githubusercontent.com/40708551/119257788-7b452a00-bbe4-11eb-88ec-4d7c683e6ba0.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-851952221


   hey @Yiyiyimu is it ready for approval?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-847657457


   > White background is not good for daylight theme
   
   have a look now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for `Slack invitation`

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-852740455


   @Yiyiyimu see examples
   ![scrnli_02_06_2021_08-55-04](https://user-images.githubusercontent.com/40708551/120429136-87727980-c392-11eb-82cf-f7bacd71ee51.png)
   ![scrnli_02_06_2021_08-56-25](https://user-images.githubusercontent.com/40708551/120429145-893c3d00-c392-11eb-919a-ff3ecab3e15f.png)
   ![scrnli_02_06_2021_08-56-48](https://user-images.githubusercontent.com/40708551/120429148-893c3d00-c392-11eb-9e8d-78e1f432de0e.png)
   
   how it will look on our website
   ![scrnli_02_06_2021_11-03-50](https://user-images.githubusercontent.com/40708551/120429152-89d4d380-c392-11eb-9b75-232f294c16d5.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-849309609


   @juzhiyuan @Yiyiyimu apisix 2.6 has been released can we now add this announcement bar?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846545541


   Deploy Preview for *apisix* ready!
   
   Built with commit 06a4be1a2e93f94306cd7fcf598a2edadbec940e
   
   https://deploy-preview-349--apisix.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on pull request #349: feat: Announcement bar added for `Slack invitation`

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-853264140


   That's pretty cool! Need confirmation from @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846544828


   @juzhiyuan @Yiyiyimu @LiteSun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#discussion_r640284373



##########
File path: website/docusaurus.config.js
##########
@@ -415,6 +415,22 @@ module.exports = {
       copyright:
         "Copyright © 2019-2021 The Apache Software Foundation. Apache APISIX, APISIX™, Apache, the Apache feather logo, and the Apache APISIX project logo are either registered trademarks or trademarks of the Apache Software Foundation.",
     },
+    announcementBar: {
+      id: 'apisix-2.6-Release',
+      backgroundColor: "#e8433e",
+      textColor: 'white',
+      content:
+        '➡️ Apache APISIX v2.6.0 released, users can view Changelogs <a target="_blank" rel="noopener noreferrer" href="https://github.com/apache/apisix/blob/2.6/CHANGELOG.md#260">APISIX 2.6.0 release</a>! 🔄',
+    },
+    /*
+    announcementBar: {
+      id: 'query',

Review comment:
       Do we need to keep this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-847410741


   > White background is not good for daylight theme
   
   Okay, will do something with that. Thanks for your opinion 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#discussion_r637551691



##########
File path: website/docusaurus.config.js
##########
@@ -415,6 +415,18 @@ module.exports = {
       copyright:
         "Copyright © 2019-2021 The Apache Software Foundation. Apache APISIX, APISIX™, Apache, the Apache feather logo, and the Apache APISIX project logo are either registered trademarks or trademarks of the Apache Software Foundation.",
     },
+    announcementBar: {
+      id: 'apisix-2.6-Release',

Review comment:
       No, 2.6 is in progress and VOTE.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-852356416


   What if we add slack invitation to the announcement bar, like many of the docusaurus based websites does?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846545541


   Deploy Preview for *apisix* ready!
   
   Built with commit f2a7c5f39b0298c0f72415ba6095d3554e1d5c14
   
   https://deploy-preview-349--apisix.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on a change in pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#discussion_r640285065



##########
File path: website/docusaurus.config.js
##########
@@ -415,6 +415,22 @@ module.exports = {
       copyright:
         "Copyright © 2019-2021 The Apache Software Foundation. Apache APISIX, APISIX™, Apache, the Apache feather logo, and the Apache APISIX project logo are either registered trademarks or trademarks of the Apache Software Foundation.",
     },
+    announcementBar: {
+      id: 'apisix-2.6-Release',
+      backgroundColor: "#e8433e",
+      textColor: 'white',
+      content:
+        '➡️ Apache APISIX v2.6.0 released, users can view Changelogs <a target="_blank" rel="noopener noreferrer" href="https://github.com/apache/apisix/blob/2.6/CHANGELOG.md#260">APISIX 2.6.0 release</a>! 🔄',
+    },
+    /*
+    announcementBar: {
+      id: 'query',

Review comment:
       Yes that will make easier for us to change the announcement just by un commenting it, docusaurus and many websites uses the same strategy




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #349: feat: Announcement bar added for `Slack invitation`

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846545541


   :construction_worker: Deploy Preview for *apisix* processing.
   
   
   :hammer: Explore the source changes: 08be0d11af8edd9bc1f8fb00e7df473b1ae75eaa
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60bf21b0905b330007bfd9c7](https://app.netlify.com/sites/apisix/deploys/60bf21b0905b330007bfd9c7?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on a change in pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#discussion_r637552816



##########
File path: website/docusaurus.config.js
##########
@@ -415,6 +415,18 @@ module.exports = {
       copyright:
         "Copyright © 2019-2021 The Apache Software Foundation. Apache APISIX, APISIX™, Apache, the Apache feather logo, and the Apache APISIX project logo are either registered trademarks or trademarks of the Apache Software Foundation.",
     },
+    announcementBar: {
+      id: 'apisix-2.6-Release',

Review comment:
       its for after release
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for `Slack invitation`

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-855532517


   @juzhiyuan could you please drop your review here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-847277898


   White background is not good for daylight theme


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#discussion_r638218038



##########
File path: website/docusaurus.config.js
##########
@@ -415,6 +415,18 @@ module.exports = {
       copyright:
         "Copyright © 2019-2021 The Apache Software Foundation. Apache APISIX, APISIX™, Apache, the Apache feather logo, and the Apache APISIX project logo are either registered trademarks or trademarks of the Apache Software Foundation.",
     },
+    announcementBar: {
+      id: 'apisix-2.6-Release',
+      content:
+        '➡️ Apache APISIX v2.6.0 released, users can view Changelogs <a target="_blank" rel="noopener noreferrer" href="https://github.com/apache/apisix/blob/release/2.6/CHANGELOG.md">APISIX 2.6.0 release</a>! 🔄',

Review comment:
       ```suggestion
           '➡️ Apache APISIX v2.6.0 released, users can view Changelogs <a target="_blank" rel="noopener noreferrer" href="https://github.com/apache/apisix/blob/2.6/CHANGELOG.md#260">APISIX 2.6.0 release</a>! 🔄',
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-847656864


   ![scrnli_25_05_2021_13-40-57](https://user-images.githubusercontent.com/40708551/119463521-78227900-bd5f-11eb-8b18-8aa7f6bd5f79.png)
   ![scrnli_25_05_2021_13-41-19](https://user-images.githubusercontent.com/40708551/119463531-7a84d300-bd5f-11eb-972e-a5597d90a4e5.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #349: feat: Announcement bar added for `Slack invitation`

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846545541


   :heavy_check_mark: Deploy Preview for *apisix* ready!
   
   
   :hammer: Explore the source changes: 193b84ae59dc3265ae44beaca523e44c09acb964
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60bd6ac32c642600071feec5](https://app.netlify.com/sites/apisix/deploys/60bd6ac32c642600071feec5?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: [https://deploy-preview-349--apisix.netlify.app](https://deploy-preview-349--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #349: feat: Announcement bar added for `Slack invitation`

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846545541


   :construction_worker: Deploy Preview for *apisix* processing.
   
   
   :hammer: Explore the source changes: 193b84ae59dc3265ae44beaca523e44c09acb964
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60bd6ac32c642600071feec5](https://app.netlify.com/sites/apisix/deploys/60bd6ac32c642600071feec5?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan merged pull request #349: feat: Announcement bar added for `Slack invitation`

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #349:
URL: https://github.com/apache/apisix-website/pull/349


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-852344233


   Sorry I just realized I'm not sure about the need of adding the announcement bar. People who enter our website would always check the latest version of APISIX so it seems could not be of much help. I think maybe it's a good to keep our welcome page as simple as possible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846545541


   Deploy Preview for *apisix* processing.
   
   Building with commit f2a7c5f39b0298c0f72415ba6095d3554e1d5c14
   
   https://app.netlify.com/sites/apisix/deploys/60aa36a1167e700007ed86f0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas edited a comment on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846544828


   cc - @juzhiyuan @Yiyiyimu @LiteSun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846545541


   Deploy Preview for *apisix* processing.
   
   Building with commit 06a4be1a2e93f94306cd7fcf598a2edadbec940e
   
   https://app.netlify.com/sites/apisix/deploys/60acb1c9ae25a30007c7da61


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #349: feat: Announcement bar added for `Slack invitation`

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-846545541


   :heavy_check_mark: Deploy Preview for *apisix* ready!
   
   
   :hammer: Explore the source changes: 08be0d11af8edd9bc1f8fb00e7df473b1ae75eaa
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60bf21b0905b330007bfd9c7](https://app.netlify.com/sites/apisix/deploys/60bf21b0905b330007bfd9c7?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: [https://deploy-preview-349--apisix.netlify.app](https://deploy-preview-349--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on pull request #349: feat: Announcement bar added for new release

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#issuecomment-852379345


   > What if we add slack invitation to the announcement bar, like many of the docusaurus based websites does?
   
   That's a good idea, could you raise some examples


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org