You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/10/07 01:21:32 UTC
Review Request 26391: Remove special casing of 'rack' attribute.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26391/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs: AURORA-662
https://issues.apache.org/jira/browse/AURORA-662
Repository: aurora
Description
-------
This patch removes the auto injection of the 'rack' attribute in the constraint of every job. This will allow for jobs without the 'rack' attribute to be scheduled and allow Aurora to schedule jobs on Mesos slaves that don't have the 'rack' attribute.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2
Diff: https://reviews.apache.org/r/26391/diff/
Testing
-------
./gradlew clean build -Pq
Thanks,
Zameer Manji
Re: Review Request 26391: Remove special casing of 'rack' attribute.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26391/#review55606
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 6, 2014, 11:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26391/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 11:21 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-662
> https://issues.apache.org/jira/browse/AURORA-662
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch removes the auto injection of the 'rack' attribute in the constraint of every job. This will allow for jobs without the 'rack' attribute to be scheduled and allow Aurora to schedule jobs on Mesos slaves that don't have the 'rack' attribute.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2
>
> Diff: https://reviews.apache.org/r/26391/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>