[GitHub] [incubator-pinot] npawar commented on pull request #6148: UI integration of instance and segment operations

[GitBox <gi...@apache.org>]

npawar commented on pull request #6148:
URL: https://github.com/apache/incubator-pinot/pull/6148#issuecomment-712354389


   > @mayankshriv
   > 
   > > * Seems like I need to do mvn install to see the UI changes (as in, IDE does not build on its own). If there's a way to automate that, it would be nice.
   > 
   > Will check that out and see what can be done but as part of another PR.
   > 
   > > * Edit Tag does not seem to take the new tag. Edit Config works for editing/adding tags.
   > 
   > We need to press `Enter`, `Space` or `Comma (,)` to create tag pills, and only then that Tag will be saved. Users can add N number of tags and that's the reason the user needs to do an extra step.
   > 
   > > * Drop: Says instance cannot be dropped as it is live.
   > 
   > UI is showing the status sent by the backend on hitting the drop API.
   
   Hey @shahsank3t , I’m seeing similar behavior as reported by Mayank for Edit Tags, but only for Server case. Broker works fine for me. Even in Server case, remove tag worked and edit config worked.
   
   @mayankshriv the drop behavior is correct. I verified that the backend is returning the message. Something seems off at the backend side. I remember we used to be able to drop instances after table has been deleted. Will check that out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org