You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "ycycse (via GitHub)" <gi...@apache.org> on 2024/06/12 13:20:36 UTC
[PR] ISSUE#12499 Reject query with massive time span in limited memroy [iotdb]
ycycse opened a new pull request, #12725:
URL: https://github.com/apache/iotdb/pull/12725
When querying with GROUP BY, if endTime is massive will result in huge number of time slots leading to Java Heap Space (see in #12499)
This PR would reject the query which may lead to above problems in advance to avoid system crash.
Relating document: https://apache-iotdb.feishu.cn/docx/IMUWdQZ4CounhEx5Z2UcdXzGnAe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 12499] Reject query with massive time span in limited memroy [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #12725:
URL: https://github.com/apache/iotdb/pull/12725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 12499] Reject query with massive time span in limited memroy [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12725:
URL: https://github.com/apache/iotdb/pull/12725#issuecomment-2163516287
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12725) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12725&metric=new_coverage&view=list) (required ≥ 80%)
 [3.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12725&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12725)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 12499] Reject query with massive time span in limited memroy [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12725:
URL: https://github.com/apache/iotdb/pull/12725#issuecomment-2163590668
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12725?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `78.94737%` with `4 lines` in your changes missing coverage. Please review.
> Project coverage is 42.06%. Comparing base [(`a64dc4c`)](https://app.codecov.io/gh/apache/iotdb/commit/a64dc4c530d8826b04097c4fb765a16237e7b4ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9d605b3`)](https://app.codecov.io/gh/apache/iotdb/commit/9d605b385f6ea4771d6a783ea77cb92349f3c03f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 18 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/iotdb/pull/12725?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../db/queryengine/plan/analyze/TemplatedAnalyze.java](https://app.codecov.io/gh/apache/iotdb/pull/12725?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fanalyze%2FTemplatedAnalyze.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9hbmFseXplL1RlbXBsYXRlZEFuYWx5emUuamF2YQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...gine/plan/analyze/TemplatedAggregationAnalyze.java](https://app.codecov.io/gh/apache/iotdb/pull/12725?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fanalyze%2FTemplatedAggregationAnalyze.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9hbmFseXplL1RlbXBsYXRlZEFnZ3JlZ2F0aW9uQW5hbHl6ZS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #12725 +/- ##
============================================
- Coverage 42.09% 42.06% -0.04%
Complexity 71 71
============================================
Files 3261 3262 +1
Lines 205664 205873 +209
Branches 24522 24562 +40
============================================
+ Hits 86580 86605 +25
- Misses 119084 119268 +184
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12725?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ISSUE#12499 Reject query with massive time span in limited memroy [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12725:
URL: https://github.com/apache/iotdb/pull/12725#issuecomment-2163011612
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12725) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12725&metric=new_coverage&view=list) (required ≥ 80%)
 [3.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12725&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12725)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org