You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2017/11/06 01:04:00 UTC
[jira] [Commented] (LUCENE-8034) SpanNotWeight returns wrong
results due to integer overflow
[ https://issues.apache.org/jira/browse/LUCENE-8034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239791#comment-16239791 ]
Michael McCandless commented on LUCENE-8034:
--------------------------------------------
Patch looks good; I'll commit soon. Thanks [~hshankar]!
But how/why are you creating such massive positions in your index in the first place?
> SpanNotWeight returns wrong results due to integer overflow
> -----------------------------------------------------------
>
> Key: LUCENE-8034
> URL: https://issues.apache.org/jira/browse/LUCENE-8034
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/query/scoring, core/search
> Reporter: Hari Menon
> Priority: Minor
> Labels: newbie, patch
> Attachments: LUCENE-8034.patch
>
>
> In SpanNotQuery, there is an acceptance condition:
> {code:java}
> if (candidate.endPosition() + post <= excludeSpans.startPosition()) {
> return AcceptStatus.YES;
> }
> {code}
> This overflows in case `candidate.endPosition() + post > Integer.MAX_VALUE`. I have a fix for this which I am working on. Basically I am flipping the add to a subtract.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org