You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Yang Ye (JIRA)" <ji...@apache.org> on 2012/05/26 01:07:23 UTC
[jira] [Comment Edited] (KAFKA-349) Create individual "Response"
types for each kind of request and wrap them with "BoundedByteBufferSend",
remove "xxResponseSend" types for all requests except "FetchRequest"
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283803#comment-13283803 ]
Yang Ye edited comment on KAFKA-349 at 5/25/12 11:07 PM:
---------------------------------------------------------
1. Replace "Requst" type with "RequestOrResponse" and move it to "kafka.api" from "kafka.network"
2. Create "FetchResponse", "ProducerResponse", "TopicMetaDataResponse", "OffsetResponse" class
3. Move the error code inside the response classes
4. Change the code in "KafkaApis" in response to the change in response formats
5. Change the Blocking channel receive function to receive just the response (with error code inside) instead of tuple of response and error code.
6. Remove unnecessary "serialization" and "deserialization" functions
7. Change corresponding test classes
was (Author: yeyangever):
1. Replace "Requst" type with "RequestOrResponse" and move it to "kafka.api" from "kafka.network"
2. Create "FetchResponse", "ProducerResponse", "TopicMetaDataResponse", "OffsetResponse" class
3. Move the error code inside the response classes
4. Change the code in "KafkaApis" in response to the change in response formats
5. Change the Blocking channel receive function to receive just the response (with error code inside) instead of tuple of response and error code.
6. Remove unnecessary "serialization" and "deserialization" functions
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira