You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/24 06:16:28 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2166: yarn add tslib [helix-front]
micahstubbs opened a new pull request, #2166:
URL: https://github.com/apache/helix/pull/2166
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
#2165
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
add tslib so that we can use --importHelpers for smaller bundle sizes with TypeScript
https://www.npmjs.com/package/tslib
https://stackoverflow.com/questions/51732554/cannot-find-module-tslib?answertab=trending#tab-top
https://github.com/angular/angular-cli/issues/13886
https://www.typescriptlang.org/tsconfig#importHelpers
### Tests
- [x] The following tests are written for this issue:
Tooling change only, no new tests.
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2166: update tslib, set import-helpers: false [helix-front]
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2166:
URL: https://github.com/apache/helix/pull/2166#issuecomment-1205695856
This PR is ready to be merged, approved by @NealSun96
Final commit message:
## update tslib, set import-helpers: false [helix-front] (#2166)
Ensure that consumers of helix-front do not themselves need tslib as a direct dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 merged pull request #2166: update tslib, set import-helpers: false [helix-front]
Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2166:
URL: https://github.com/apache/helix/pull/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2166: update tslib, set import-helpers: false [helix-front]
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2166:
URL: https://github.com/apache/helix/pull/2166#issuecomment-1205693671
CI failure appears to be an unrelated ZK timeout:
```
45828 [ZkClient-AsyncCallback-Retry-206-localhost:2127] ERROR org.apache.helix.zookeeper.zkclient.callback.ZkAsyncRetryThread [] - Error retrying callback org.apache.helix.zookeeper.impl.client.TestZkClientAsyncRetry$MockAsyncZkClient$1@4278a9b7, cancelling it
org.apache.helix.zookeeper.zkclient.exception.ZkException: null
```
https://github.com/apache/helix/runs/7662436946?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org