[GitHub] [cordova-windows] wifisher edited a comment on issue #322: SplashScreen tag name does not match entry in Windows 10 Manifest file on some devices

[GitBox <gi...@apache.org>]

wifisher edited a comment on issue #322: SplashScreen tag name does not match entry in Windows 10 Manifest file on some devices
URL: https://github.com/apache/cordova-windows/issues/322#issuecomment-481292910
 
 
   Same issue here. Breaks reading of the splashscreen preferences from the config.xml file.
   
   A simple try/catch block in confighelper.js would get it working again:
   
   ```javascript
   function Manifest(text) {
       XmlFile.apply(this, arguments);
      try {
           this.splashScreen = this.loadTags(splashScreenTagName)[0];
      }
      catch(e) {
           if(isWin10UWP) {
              this.splashScreen = this.loadTags("uap:" + splashScreenTagName)[0];
           } else {
              throw e;
           }
      }
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org