You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/01/06 00:53:36 UTC

[GitHub] [activemq-nms-openwire] michaelandrepearce edited a comment on pull request #12: Implemented necessary signaling for Shutdown() and ShutDownWithAbort()

michaelandrepearce edited a comment on pull request #12:
URL: https://github.com/apache/activemq-nms-openwire/pull/12#issuecomment-754991213


   @troutkilroy i was about to look to merge this, but noticed there is no test case, can you add a test case for this please. 
   a) to demonstrate the issue
   b) prove that this fix does fix the issue
   c) ensure the issue is not regressed by 
   
   as well can you raise a JIRA item, https://issues.apache.org/jira/projects/AMQNET/issues/ for the issue, and update the commit message to contain prefix with the Jira item.
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org