You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/22 15:47:27 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #846: ci: enable CI for all release branches
nic-chen opened a new pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#issuecomment-731767704
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`v2.1@4416e3d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v2.1 #846 +/- ##
=======================================
Coverage ? 42.56%
=======================================
Files ? 18
Lines ? 1257
Branches ? 0
=======================================
Hits ? 535
Misses ? 631
Partials ? 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=footer). Last update [4416e3d...fcdbf48](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on a change in pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#discussion_r528460417
##########
File path: .github/workflows/backend-cli-test.yml
##########
@@ -4,11 +4,11 @@ on:
push:
branches:
- master
- - v2.0
+ - v**
Review comment:
Why we not develop in `master` or `development`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#discussion_r528486858
##########
File path: .github/workflows/backend-cli-test.yml
##########
@@ -4,11 +4,11 @@ on:
push:
branches:
- master
- - v2.0
+ - v**
Review comment:
Good idea, could we merge 2.1 into 2.0 now? We should develop on the master branch indeed.
cc @mooming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#discussion_r528489562
##########
File path: .github/workflows/backend-cli-test.yml
##########
@@ -4,11 +4,11 @@ on:
push:
branches:
- master
- - v2.0
+ - v**
Review comment:
yes,
```
branches:
- master
```
is good enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#discussion_r528487872
##########
File path: .github/workflows/backend-cli-test.yml
##########
@@ -4,11 +4,11 @@ on:
push:
branches:
- master
- - v2.0
+ - v**
Review comment:
en, we should always develop on master branch,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#discussion_r528451948
##########
File path: .github/workflows/backend-cli-test.yml
##########
@@ -4,11 +4,11 @@ on:
push:
branches:
- master
- - v2.0
+ - v**
Review comment:
But they may not read the README, I prefer to write comments directly, although it is more cumbersome.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#issuecomment-731954778
will close this pr and create a new one later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#discussion_r528457806
##########
File path: .github/workflows/backend-cli-test.yml
##########
@@ -4,11 +4,11 @@ on:
push:
branches:
- master
- - v2.0
+ - v**
Review comment:
hmmm not sure, `v**` is too mixed to understand, just waiting for others' comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#discussion_r528486858
##########
File path: .github/workflows/backend-cli-test.yml
##########
@@ -4,11 +4,11 @@ on:
push:
branches:
- master
- - v2.0
+ - v**
Review comment:
Good idea, could we merge 2.1 into 2.0 now? We should develop on the master branch indeed.
cc @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#issuecomment-731767704
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`v2.1@4416e3d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v2.1 #846 +/- ##
=======================================
Coverage ? 42.64%
=======================================
Files ? 18
Lines ? 1257
Branches ? 0
=======================================
Hits ? 536
Misses ? 630
Partials ? 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=footer). Last update [4416e3d...fcdbf48](https://codecov.io/gh/apache/apisix-dashboard/pull/846?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#issuecomment-731953633
@nic-chen please submit PR based on `master`, and merge to `master` too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
nic-chen closed pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #846: ci: enable CI for all release branches
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #846:
URL: https://github.com/apache/apisix-dashboard/pull/846#discussion_r528429387
##########
File path: .github/workflows/backend-cli-test.yml
##########
@@ -4,11 +4,11 @@ on:
push:
branches:
- master
- - v2.0
+ - v**
Review comment:
Someone may don't know what happened here, could we add a README instead of multiple comments under .github folder?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org