You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2018/07/27 05:27:26 UTC
spark git commit: [SPARK-24829][STS] In Spark Thrift Server,
CAST AS FLOAT inconsistent with spark-shell or spark-sql
Repository: spark
Updated Branches:
refs/heads/master 094aa5971 -> dc3713cca
[SPARK-24829][STS] In Spark Thrift Server, CAST AS FLOAT inconsistent with spark-shell or spark-sql
## What changes were proposed in this pull request?
SELECT CAST('4.56' AS FLOAT)
the result is 4.559999942779541
it should be 4.56 as same as in spark-shell or spark-sql.
## How was this patch tested?
add unit tests
Author: zuotingbing <zu...@zte.com.cn>
Closes #21789 from zuotingbing/SPARK-24829.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/dc3713cc
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/dc3713cc
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/dc3713cc
Branch: refs/heads/master
Commit: dc3713cca22e2ac66ad0a4206b0a09e289167137
Parents: 094aa59
Author: zuotingbing <zu...@zte.com.cn>
Authored: Fri Jul 27 13:27:17 2018 +0800
Committer: hyukjinkwon <gu...@apache.org>
Committed: Fri Jul 27 13:27:17 2018 +0800
----------------------------------------------------------------------
.../java/org/apache/hive/service/cli/Column.java | 2 +-
.../hive/thriftserver/HiveThriftServer2Suites.scala | 16 ++++++++++++++++
2 files changed, 17 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/dc3713cc/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/Column.java
----------------------------------------------------------------------
diff --git a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/Column.java b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/Column.java
index 2e21f18..adb269a 100644
--- a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/Column.java
+++ b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/Column.java
@@ -349,7 +349,7 @@ public class Column extends AbstractList {
break;
case FLOAT_TYPE:
nulls.set(size, field == null);
- doubleVars()[size] = field == null ? 0 : ((Float)field).doubleValue();
+ doubleVars()[size] = field == null ? 0 : new Double(field.toString());
break;
case DOUBLE_TYPE:
nulls.set(size, field == null);
http://git-wip-us.apache.org/repos/asf/spark/blob/dc3713cc/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
----------------------------------------------------------------------
diff --git a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
index 192f33a..70eb28c 100644
--- a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
+++ b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
@@ -636,6 +636,14 @@ class HiveThriftBinaryServerSuite extends HiveThriftJdbcTest {
assert(pipeoutFileList(sessionID).length == 0)
}
}
+
+ test("SPARK-24829 Checks cast as float") {
+ withJdbcStatement() { statement =>
+ val resultSet = statement.executeQuery("SELECT CAST('4.56' AS FLOAT)")
+ resultSet.next()
+ assert(resultSet.getString(1) === "4.56")
+ }
+ }
}
class SingleSessionSuite extends HiveThriftJdbcTest {
@@ -766,6 +774,14 @@ class HiveThriftHttpServerSuite extends HiveThriftJdbcTest {
assert(resultSet.getString(2) === HiveUtils.builtinHiveVersion)
}
}
+
+ test("SPARK-24829 Checks cast as float") {
+ withJdbcStatement() { statement =>
+ val resultSet = statement.executeQuery("SELECT CAST('4.56' AS FLOAT)")
+ resultSet.next()
+ assert(resultSet.getString(1) === "4.56")
+ }
+ }
}
object ServerMode extends Enumeration {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org