You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by gr...@apache.org on 2020/10/27 18:47:00 UTC
[royale-asjs] branch develop updated: Quick fixes for build. Quick
comment: The drag-drop support might needs review,
because it has a Royale Collections dependency which may mean it does not
work as-is with mxroyale ArrayCollection- needs checking.
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 8ebe005 Quick fixes for build. Quick comment: The drag-drop support might needs review, because it has a Royale Collections dependency which may mean it does not work as-is with mxroyale ArrayCollection- needs checking.
8ebe005 is described below
commit 8ebe005acd47afb6928a54e7d0aab69ce8736ceb
Author: greg-dove <gr...@gmail.com>
AuthorDate: Wed Oct 28 07:46:44 2020 +1300
Quick fixes for build.
Quick comment: The drag-drop support might needs review, because it has a Royale Collections dependency which may mean it does not work as-is with mxroyale ArrayCollection- needs checking.
---
frameworks/projects/SparkRoyale/pom.xml | 28 ++++++++++++++++++++++
.../src/main/royale/spark/components/List.as | 6 +++--
.../components/supportClasses/ItemRenderer.as | 4 ++--
3 files changed, 34 insertions(+), 4 deletions(-)
diff --git a/frameworks/projects/SparkRoyale/pom.xml b/frameworks/projects/SparkRoyale/pom.xml
index ce56c4d..0d34770 100644
--- a/frameworks/projects/SparkRoyale/pom.xml
+++ b/frameworks/projects/SparkRoyale/pom.xml
@@ -113,6 +113,20 @@
<type>swc</type>
<classifier>js</classifier>
</dependency>
+ <dependency>
+ <groupId>org.apache.royale.framework</groupId>
+ <artifactId>DragDrop</artifactId>
+ <version>0.9.8-SNAPSHOT</version>
+ <type>swc</type>
+ <classifier>js</classifier>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.royale.framework</groupId>
+ <artifactId>Collections</artifactId>
+ <version>0.9.8-SNAPSHOT</version>
+ <type>swc</type>
+ <classifier>js</classifier>
+ </dependency>
</dependencies>
<profiles>
@@ -189,6 +203,20 @@
<type>swc</type>
<classifier>swf</classifier>
</dependency>
+ <dependency>
+ <groupId>org.apache.royale.framework</groupId>
+ <artifactId>DragDrop</artifactId>
+ <version>0.9.8-SNAPSHOT</version>
+ <type>swc</type>
+ <classifier>swf</classifier>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.royale.framework</groupId>
+ <artifactId>Collections</artifactId>
+ <version>0.9.8-SNAPSHOT</version>
+ <type>swc</type>
+ <classifier>swf</classifier>
+ </dependency>
</dependencies>
</profile>
</profiles>
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/List.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/List.as
index 3c1fded..c18cd7c 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/List.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/List.as
@@ -763,7 +763,9 @@ public class List extends ListBase implements IFocusManagerComponent
*/
/* private var _dragEnabled:Boolean = false;
- [Inspectable(defaultValue="false")] */
+ // [Inspectable(defaultValue="false")]
+
+ */
/**
* A flag that indicates whether you can drag items out of
@@ -819,7 +821,7 @@ public class List extends ListBase implements IFocusManagerComponent
*/
private var _dragMoveEnabled:Boolean = false;
- [Inspectable(defaultValue="false")] */
+ /* [Inspectable(defaultValue="false")] */
/**
* A flag that indicates whether items can be moved instead
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ItemRenderer.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ItemRenderer.as
index 5861746..f599776 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ItemRenderer.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ItemRenderer.as
@@ -346,7 +346,7 @@ public class ItemRenderer extends DataRenderer implements IItemRenderer
*/
private var _itemIndex:int;
- [Bindable("itemIndexChanged")] */
+ /*@todo review this: [Bindable("itemIndexChanged")] */
/**
* @inheritDoc
@@ -372,7 +372,7 @@ public class ItemRenderer extends DataRenderer implements IItemRenderer
return;
_itemIndex = value;
-
+ //@todo does this need to dispatch "itemIndexChanged" to support Bindable ?
//if (autoDrawBackground)
//{
//redrawRequested = true;