[jira] [Commented] (MESOS-8993) `network/ports` and `network/ports_mapping` isolators are missing from CMake build

["Andrew Schwartzmeyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565984#comment-16565984 ] 

Andrew Schwartzmeyer commented on MESOS-8993:
---------------------------------------------

commit 3bd7711b1 (HEAD -> master, origin/rb/missing-files, rb/missing-files)
Author: Andrew Schwartzmeyer 
Date:   Fri Jul 27 11:57:14 2018 -0700

    Added port mapping and network ports isolators sources to CMake.
    
    This adds the relevant options and source files, but with a fatal
    message if they're used, as we do not yet check for their
    dependencies. This also adds the `mesos-network-helper` executable as
    used by the port mapping isolator.
    
    Review: https://reviews.apache.org/r/68094

> `network/ports` and `network/ports_mapping` isolators are missing from CMake build
> ----------------------------------------------------------------------------------
>
>                 Key: MESOS-8993
>                 URL: https://issues.apache.org/jira/browse/MESOS-8993
>             Project: Mesos
>          Issue Type: Bug
>          Components: cmake
>    Affects Versions: 1.7.0
>         Environment: Linux with CMake
>            Reporter: Andrew Schwartzmeyer
>            Assignee: James Peach
>            Priority: Major
>              Labels: cmake
>
> The `network/ports` _and_ `network/port_mapping` isolators are completely missing from the CMake build. It the port_mapping one looks like it needs libnl-3, and the files we need are src/tests/containerizer/ports_isolator_tests.cpp, tests/containerizer/port_mapping_tests.cpp, and src/slave/containerizer/mesos/isolators/network/ports.cpp, along with a configuration option network-ports-isolator.
> Note that this was discovered due to a build break in the associated tests as they were missing from the build I ran as a test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)