You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Berezhniuk (JIRA)" <ji...@apache.org> on 2007/08/31 19:37:19 UTC
[jira] Created: (HARMONY-4715) [drlvm][thread] hythr module ignores
vm.assert_dialog property
[drlvm][thread] hythr module ignores vm.assert_dialog property
--------------------------------------------------------------
Key: HARMONY-4715
URL: https://issues.apache.org/jira/browse/HARMONY-4715
Project: Harmony
Issue Type: Bug
Components: DRLVM
Environment: Windows
Reporter: Ilya Berezhniuk
When assertion occurs in hythr module, it shows Windows assert dialog regardless of vm.assert_dialog property value, because it doesn't turn it off when vm.assert_dialog is false.
Another modules call disable_assert_dialogs() function to perform this, but they also check vm.assert_dialog VM property before this.
To keep abstraction, hythr cannot call this function, but hythr can copy-paste its content.
Also hythr cannot ask for VM property - it pretends it knows nothing about the VM. So I think 'enable/disable' flag should be passed as a parameter to one of hythr init functions - like hythread_lib_create(). The problem is in the following: no one calls hythread_lib_create(), it's called automatically during library initialization. Thus we can't pass VM property value to hythr during its initialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4715) [drlvm][thread] hythr module ignores
vm.assert_dialog property
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weldon washburn updated HARMONY-4715:
-------------------------------------
Priority: Minor (was: Major)
> [drlvm][thread] hythr module ignores vm.assert_dialog property
> --------------------------------------------------------------
>
> Key: HARMONY-4715
> URL: https://issues.apache.org/jira/browse/HARMONY-4715
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Priority: Minor
>
> When assertion occurs in hythr module, it shows Windows assert dialog regardless of vm.assert_dialog property value, because it doesn't turn it off when vm.assert_dialog is false.
> Another modules call disable_assert_dialogs() function to perform this, but they also check vm.assert_dialog VM property before this.
> To keep abstraction, hythr cannot call this function, but hythr can copy-paste its content.
> Also hythr cannot ask for VM property - it pretends it knows nothing about the VM. So I think 'enable/disable' flag should be passed as a parameter to one of hythr init functions - like hythread_lib_create(). The problem is in the following: no one calls hythread_lib_create(), it's called automatically during library initialization. Thus we can't pass VM property value to hythr during its initialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4715) [drlvm][thread] hythr module
ignores vm.assert_dialog property
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov resolved HARMONY-4715.
--------------------------------------
Resolution: Fixed
Assignee: Alexey Varlamov
Fixed with HARMONY-4973 at r602080.
> [drlvm][thread] hythr module ignores vm.assert_dialog property
> --------------------------------------------------------------
>
> Key: HARMONY-4715
> URL: https://issues.apache.org/jira/browse/HARMONY-4715
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assignee: Alexey Varlamov
> Priority: Minor
>
> When assertion occurs in hythr module, it shows Windows assert dialog regardless of vm.assert_dialog property value, because it doesn't turn it off when vm.assert_dialog is false.
> Another modules call disable_assert_dialogs() function to perform this, but they also check vm.assert_dialog VM property before this.
> To keep abstraction, hythr cannot call this function, but hythr can copy-paste its content.
> Also hythr cannot ask for VM property - it pretends it knows nothing about the VM. So I think 'enable/disable' flag should be passed as a parameter to one of hythr init functions - like hythread_lib_create(). The problem is in the following: no one calls hythread_lib_create(), it's called automatically during library initialization. Thus we can't pass VM property value to hythr during its initialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.