You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Max Starets (JIRA)" <de...@myfaces.apache.org> on 2011/02/14 23:24:57 UTC

[jira] Created: (TRINIDAD-2034) DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects

DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects
------------------------------------------------------------------------

                 Key: TRINIDAD-2034
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2034
             Project: MyFaces Trinidad
          Issue Type: Bug
            Reporter: Max Starets
            Assignee: Max Starets


When DatePropertyTagRule and StringArrayPropertyTagRule are applied to attributes specified as string literals, the parsing results are cached on the tag. The issue is that the parsing results are mutable (java.util.Date and String[]), so they a) cannot be shared; b) cannot be cached. 

The fix will be to clone a new object every time LiteralPropertyMetadata.applyMetadata() is called.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (TRINIDAD-2034) DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects

Posted by "Max Starets (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Max Starets updated TRINIDAD-2034:
----------------------------------

    Status: Patch Available  (was: Open)

> DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects
> ------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2034
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2034
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>            Reporter: Max Starets
>            Assignee: Max Starets
>
> When DatePropertyTagRule and StringArrayPropertyTagRule are applied to attributes specified as string literals, the parsing results are cached on the tag. The issue is that the parsing results are mutable (java.util.Date and String[]), so they a) cannot be shared; b) cannot be cached. 
> The fix will be to clone a new object every time LiteralPropertyMetadata.applyMetadata() is called.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (TRINIDAD-2034) DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects

Posted by "Max Starets (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Max Starets updated TRINIDAD-2034:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

> DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects
> ------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2034
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2034
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>            Reporter: Max Starets
>            Assignee: Max Starets
>         Attachments: trinidad-2034.diff
>
>
> When DatePropertyTagRule and StringArrayPropertyTagRule are applied to attributes specified as string literals, the parsing results are cached on the tag. The issue is that the parsing results are mutable (java.util.Date and String[]), so they a) cannot be shared; b) cannot be cached. 
> The fix will be to clone a new object every time LiteralPropertyMetadata.applyMetadata() is called.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira