[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520863#comment-17520863 ] 

Julian Hyde commented on CALCITE-5085:
--------------------------------------

Raghav, I ran {{RelToSqlConverterTest.testSubstring}} in a debugger. The {{FireboltSqlDialect.identifierNeedsQuote}} method seems to be at fault. The comment says "By default, all identifiers are quoted" but the implementation seems to quote ONLY reserved keywords.

> Firebolt dialect implementation
> -------------------------------
>
>                 Key: CALCITE-5085
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5085
>             Project: Calcite
>          Issue Type: New Feature
>          Components: jdbc-adapter
>            Reporter: Kevin Marr
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Firebolt is a columnar MPP cloud data warehouse with decoupled storage and compute. https://www.firebolt.io/
> It closely follows PostgreSQL but has enough differences to warrant a separate dialect in Calcite. We would like to add this dialect to make it easier for any BI/modeling vendors using Calcite to implement Firebolt connectors.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)