You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mark4z (via GitHub)" <gi...@apache.org> on 2023/06/04 03:15:35 UTC

[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #540: Control Panel: Feat/service metadata

mark4z commented on PR #540:
URL: https://github.com/apache/dubbo-go-pixiu/pull/540#issuecomment-1575356186

   Fix test like this  in TestInitPushContext
   
   ```go
   	// Check to ensure the update is identical to the old one
   	// There is probably a better way to do this.
   	diff := cmp.Diff(old, newPush,
   		// AllowUnexported for metadataindex
   		cmp.AllowUnexported(PushContext{}, exportToDefaults{}, serviceIndex{}, virtualServiceIndex{},
   			destinationRuleIndex{}, gatewayIndex{}, consolidatedDestRules{}, IstioEgressListenerWrapper{}, SidecarScope{},
   			AuthenticationPolicies{}, NetworkManager{}, sidecarIndex{}, Telemetries{}, ProxyConfigs{}, consolidatedDestRule{}, serviceNameMappingIndex{}),
   		// These are not feasible/worth comparing
   		cmpopts.IgnoreTypes(sync.RWMutex{}, localServiceDiscovery{}, FakeStore{}, atomic.Bool{}, sync.Mutex{}),
   		cmpopts.IgnoreInterfaces(struct{ mesh.Holder }{}),
   		protocmp.Transform(),
   	)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org