[jira] [Commented] (NUMBERS-123) "BigFraction(double)" is unnecessary

["Heinrich Bohne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUMBERS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875890#comment-16875890 ] 

Heinrich Bohne commented on NUMBERS-123:
----------------------------------------

The Javadoc still needs to be updated in two places, here's a patch. [^NUMBERS-123__Javadoc.patch] 

> "BigFraction(double)" is unnecessary
> ------------------------------------
>
>                 Key: NUMBERS-123
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-123
>             Project: Commons Numbers
>          Issue Type: Improvement
>          Components: fraction
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Trivial
>             Fix For: 1.0
>
>         Attachments: NUMBERS-123__Javadoc.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Constructor {{BigFraction(double value)}} is only called from the {{from(double value)}} method.
>  Actually, this constructor is misleading as it is indeed primarily a conversion from which appropriate {{numerator}} and {{denominator}} fields are computed; those could be set by
>  the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.
> Moreover, the private field {{ZERO}} goes through this conversion code whereas it could constructed "directly", e.g. using {{of(0)}}. Similarly for field {{ONE}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)