[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API
URL: https://github.com/apache/incubator-pinot/pull/4362#discussion_r297273221
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/io/writer/impl/MutableOffHeapByteArrayStore.java
 ##########
 @@ -157,7 +150,7 @@ public void close()
       _pinotDataBuffer.close();
     }
 
-    private long getSize() {
+    private int getSize() {
 
 Review comment:
   I think we should support long. At the time this was coded, Lbuffer support had bugs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org