[GitHub] [tvm] areusch commented on a change in pull request #10425: Add remaining targets to ci.py

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #10425:
URL: https://github.com/apache/tvm/pull/10425#discussion_r821023704



##########
File path: tests/scripts/ci.py
##########
@@ -77,6 +81,11 @@ def cmd(commands: List[Any], **kwargs: Any):
     return proc
 
 
+def get_build_dir(type: str) -> str:

Review comment:
       should we key off image name instead of type? probably not generally valid to take one build to another img

##########
File path: tests/scripts/ci.py
##########
@@ -178,6 +213,8 @@ def docker(name: str, image: str, scripts: List[str], env: Dict[str, str]):
         clean_exit(f"Error invoking Docker: {e}")
     except KeyboardInterrupt:
         cmd(["docker", "stop", "--time", "1", name])
+    finally:
+        script_file.unlink()

Review comment:
       should we have a debug mode here which doesn't remove the script? or is the idea you debug it anyway via the trap above?

##########
File path: python/tvm/_ffi/libinfo.py
##########
@@ -68,6 +72,10 @@ def get_dll_directories():
     dll_path.append(os.path.join(ffi_dir, ".."))
     # Default cmake build directory
     dll_path.append(os.path.join(source_dir, "build"))
+
+    # Other possible build directories
+    dll_path += list(REPO_ROOT.glob("build-*"))

Review comment:
       can you use source_dir here instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org