You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/04/15 13:39:23 UTC

[GitHub] [camel-k] claudio4j opened a new pull request, #3213: Update camel-k-runtime to 1.13.0 in defaults

claudio4j opened a new pull request, #3213:
URL: https://github.com/apache/camel-k/pull/3213

   Also update the dataformat name coming from camel-k catalog,
   the json prefix was removed
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez commented on pull request #3213: Update camel-k-runtime to 1.13.0 in defaults

Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3213:
URL: https://github.com/apache/camel-k/pull/3213#issuecomment-1101387919

   Agree with @oscerd. After all, the `package-artifact` is only used in the `make images-dev` whose original goal is to help developers to bundle local (SNAPSHOT) dependencies.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] claudio4j commented on a diff in pull request #3213: Update camel-k-runtime to 1.13.0 in defaults

Posted by GitBox <gi...@apache.org>.
claudio4j commented on code in PR #3213:
URL: https://github.com/apache/camel-k/pull/3213#discussion_r852079371


##########
pkg/util/source/inspector_yaml.go:
##########
@@ -73,7 +73,7 @@ func (i YAMLInspector) parseStep(key string, content interface{}, meta *Metadata
 				dataFormatID := defaultJSONDataFormat
 				if jsContent, jsContentOk := js.(map[interface{}]interface{}); jsContentOk {
 					if lib, libOk := jsContent["library"]; libOk {
-						dataFormatID = strings.ToLower(fmt.Sprintf("json-%s", lib))
+						dataFormatID = strings.ToLower(fmt.Sprint(lib))

Review Comment:
   It's safer to use the string formatter, thanks for noticing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] claudio4j closed pull request #3213: Update camel-k-runtime to 1.13.0 in defaults

Posted by GitBox <gi...@apache.org>.
claudio4j closed pull request #3213: Update camel-k-runtime to 1.13.0 in defaults
URL: https://github.com/apache/camel-k/pull/3213


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez commented on a diff in pull request #3213: Update camel-k-runtime to 1.13.0 in defaults

Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3213:
URL: https://github.com/apache/camel-k/pull/3213#discussion_r851979895


##########
pkg/util/source/inspector_yaml.go:
##########
@@ -73,7 +73,7 @@ func (i YAMLInspector) parseStep(key string, content interface{}, meta *Metadata
 				dataFormatID := defaultJSONDataFormat
 				if jsContent, jsContentOk := js.(map[interface{}]interface{}); jsContentOk {
 					if lib, libOk := jsContent["library"]; libOk {
-						dataFormatID = strings.ToLower(fmt.Sprintf("json-%s", lib))
+						dataFormatID = strings.ToLower(fmt.Sprint(lib))

Review Comment:
   Should'nt be `fmt.Sprintf("%s", lib)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] oscerd commented on pull request #3213: Update camel-k-runtime to 1.13.0 in defaults

Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #3213:
URL: https://github.com/apache/camel-k/pull/3213#issuecomment-1101386238

   I think it"s probably safe to try to release and see. Setting up the ci with staging repo is too much headache


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] claudio4j commented on pull request #3213: Update camel-k-runtime to 1.13.0 in defaults

Posted by GitBox <gi...@apache.org>.
claudio4j commented on PR #3213:
URL: https://github.com/apache/camel-k/pull/3213#issuecomment-1100724357

   Many CI tests failed because it tried to download from https://repo1.maven.org/maven2/ public repo, but as 1.13.0 is not in public repo yet, the package_artifacts.sh should download from staging repo. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] claudio4j commented on pull request #3213: Update camel-k-runtime to 1.13.0 in defaults

Posted by GitBox <gi...@apache.org>.
claudio4j commented on PR #3213:
URL: https://github.com/apache/camel-k/pull/3213#issuecomment-1101374486

   The use of staging maven repo allowed to download the camel-k-runtime source zip, but the `mvn dependency:copy-dependencies` failed for the same reason as the camel-k-runtime artifacts could not be resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org