You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/12/24 19:16:23 UTC

DO NOT REPLY [Bug 52384] New: URL parameter without value should be parsed successfully when logging level = DEBUG

https://issues.apache.org/bugzilla/show_bug.cgi?id=52384

             Bug #: 52384
           Summary: URL parameter without value should be parsed
                    successfully when logging level = DEBUG
           Product: Tomcat 7
           Version: 7.0.23
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: spamcollector@yandex.ru
    Classification: Unclassified


Create a simple servlet with 

protected void doGet(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
    request.getParameterMap();
}

Start Tomcat under Eclipse, or force logging level for class
org.apache.tomcat.util.http.Parameters to be "DEBUG"
Call the servlet with parameter which has no value set, e.g.

http://localhost:8080/mywebapp/myservlet?parameterWithotValue

(so only the "parameterWithotValue" should be in the result of
request.getParameterMap())

enjoy exception:

java.lang.ArrayIndexOutOfBoundsException
    at java.lang.System.arraycopy(Native Method)
    at org.apache.tomcat.util.buf.ByteChunk.append(ByteChunk.java:334)
    at
org.apache.tomcat.util.http.Parameters.processParameters(Parameters.java:347)
    at
org.apache.tomcat.util.http.Parameters.processParameters(Parameters.java:425)
    at
org.apache.tomcat.util.http.Parameters.handleQueryParameters(Parameters.java:189)
    at org.apache.catalina.connector.Request.parseParameters(Request.java:2993)
    at
org.apache.catalina.connector.Request.getParameterNames(Request.java:1185)
    at org.apache.catalina.connector.Request.getParameterMap(Request.java:1164)
    at
org.apache.catalina.connector.RequestFacade.getParameterMap(RequestFacade.java:444)
    at ru.agapemoda.servlet.ImageServlet.doGet(ImageServlet.java:47)
             ......................................................
    at java.lang.Thread.run(Thread.java:662)

Note: when logging level is "SEVERE", the troublesome code in
org.apache.tomcat.util.http.Parameters.processParameters(Parameters.java:347) 

            if (log.isDebugEnabled()) {
                try {
                    origName.append(bytes, nameStart, nameEnd - nameStart);
                    origValue.append(bytes, valueStart, valueEnd - valueStart);
                } catch (IOException ioe) {
                    // Should never happen...
                    log.error(sm.getString("parameters.copyFail"), ioe);
                }
            }

is not executed and parameter is being parsed successfully. Should be parsed
successfully with log level = "DEBUG" as well.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 52384] URL parameter without value should be parsed successfully when logging level = DEBUG

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52384

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Catalina                    |Catalina
            Version|7.0.23                      |6.0.35
            Product|Tomcat 7                    |Tomcat 6
   Target Milestone|---                         |default

--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> 2011-12-25 23:40:17 UTC ---
Fixed in 7.0 and will be in 7.0.24.

The issue also affects 6.0.35 and not yet released code in 5.5.x branch.
Proposed for 6.0 and 5.5.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 52384] URL parameter without value should be parsed successfully when logging level = DEBUG

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52384

--- Comment #4 from Jackie Rosen <ja...@hushmail.com> ---
*** Bug 260998 has been marked as a duplicate of this bug. ***
Seen from the domain http://volichat.com
Page where seen: http://volichat.com/adult-chat-rooms
Marked for reference. Resolved as fixed @bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 52384] URL parameter without value should be parsed successfully when logging level = DEBUG

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52384

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> 2012-01-09 04:54:29 UTC ---
Fixed in 6.0 with r1229027 and will be in 6.0.36.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 52384] URL parameter without value should be parsed successfully when logging level = DEBUG

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52384

--- Comment #2 from Konstantin Kolinko <kn...@gmail.com> 2012-01-06 14:15:27 UTC ---
Fixed in 5.5 with r1228191 and will be in 5.5.35.
Just noting that the issue was in not-yet-released code. It does not affect any
released 5.5 versions.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org