You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/18 16:13:28 UTC
[GitHub] [pulsar-site] tisonkun opened a new pull request, #148: Remove locales we don't support yet
tisonkun opened a new pull request, #148:
URL: https://github.com/apache/pulsar-site/pull/148
Otherwise when a user change the language but found the result is just English, it's not a good experience.
If we don't support it, we don't mention it. We can also add them back when there is real translated contents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #148:
URL: https://github.com/apache/pulsar-site/pull/148#issuecomment-1188567099
@tisonkun double check: do you want to preview localized pages? Seems that they can not be previewed, correct? @urfreespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #148:
URL: https://github.com/apache/pulsar-site/pull/148#issuecomment-1189035515
If we keep showing the languages, it works as a reminder that you can make contributions to localization work, or else the community might not know these languages are supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #148:
URL: https://github.com/apache/pulsar-site/pull/148#issuecomment-1188605008
If you want to preview changes locally, then `./preview.sh` is OK and enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tuhaihe commented on pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
tuhaihe commented on PR #148:
URL: https://github.com/apache/pulsar-site/pull/148#issuecomment-1189717554
l10n work are organized via [Apache Pulsar @Crowdin](https://crowdin.com/project/apache-pulsar) project. Some translation progress for different languages for the old website, including ZH, JP, etc. But the new website made all the translation work failure. In the following weeks, I can help contact the contributors to rework on the translation.
So let's keep them first. No rush to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #148:
URL: https://github.com/apache/pulsar-site/pull/148#issuecomment-1188570313
@Anonymitaet I make this patch with intention to avoid display language options which we don't have a real translated content. However, I don't know whether I change it correctly. I'd like to verify it locally, no matter is "localized pages" or other approach.
For example, when I execute `/preview.sh`, I get:
<img width="682" alt="image" src="https://user-images.githubusercontent.com/18818196/179662100-bbefdc2d-d296-4251-ad81-a13344864ab8.png">
.. it seems other options are populated in a following step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #148:
URL: https://github.com/apache/pulsar-site/pull/148#issuecomment-1189038507
> community might not know these languages are supported.
Do we support those languages? If so, how to?
> it works as a reminder that you can make contributions to localization work
We'd better to place documents about how to document (including how to translate), instead such a unintuitive association.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #148:
URL: https://github.com/apache/pulsar-site/pull/148#issuecomment-1188492252
@Anonymitaet thanks for your reaction. Since we don't run any CI tasks to dry run and verify the build, may I ask how to verify all changes looks good locally? I've run `./preview.sh`, but it only generates English version.
cc @urfreespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun closed pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #148: Remove locales we don't support yet
URL: https://github.com/apache/pulsar-site/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #148:
URL: https://github.com/apache/pulsar-site/pull/148#issuecomment-1188619227
@Anonymitaet thank you. Then I'm waiting for more review comments.
The original purpose to make this change is "If we don't support it, we don't mention it". Even if we _have a plan_ to offer those translated contents, we can re-add the language switch option when they're present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #148: Remove locales we don't support yet
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #148:
URL: https://github.com/apache/pulsar-site/pull/148#issuecomment-1189720229
@tuhaihe thanks for your information. Then here could be a first step to mention the translation status in the repo or on the site.
Closed as invalid. Though the status should be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org